Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucket Quantity Issue with Forge #463

Closed
Dockter opened this issue Mar 28, 2018 · 3 comments
Closed

Bucket Quantity Issue with Forge #463

Dockter opened this issue Mar 28, 2018 · 3 comments

Comments

@Dockter
Copy link
Member

Dockter commented Mar 28, 2018

A user has found this problem.

Issue: clicking on a tinkers construct seared tank with a lava bucket with a quantity > 1 when the tank is full will result in the tank eating 1 bucker of lava, stack de-increments. If quantity==1 then the issue does not occur.

Code: Possible code issue is I believe in Forge specifically with " public static IFluidHandlerItem getFluidHandler(@nonnull ItemStack itemStack)"

TinkersConstruct onBlockActivated Code: https://github.com/SlimeKnights/TinkersConstruct/blob/master/src/main/java/slimeknights/tconstruct/smeltery/block/BlockTank.java#L94

Forge Code Link: https://github.com/MinecraftForge/MinecraftForge/blob/1.12.x/src/main/java/net/minecraftforge/fluids/FluidUtil.java#L470 This specifically says the itemStack will be modified, which is what I assume is causing the buckets to be eaten.

Looking for a possible solution to this other than removing the ability to stack buckets.

@Dockter
Copy link
Member Author

Dockter commented Mar 28, 2018

One possible solution would be to create a new Almura bucket based on the forge "Universal Bucket" base item?

@liach
Copy link
Contributor

liach commented Mar 28, 2018

I do not think universal bucket fixes this issue. UB also assumes the stack size is always 1.

@Dockter
Copy link
Member Author

Dockter commented Apr 19, 2018

Added to Almura 3.0 - 1.5 Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants