NPE on seek

[dankearns]

If the first call on an open s3a stream is to seek, the log statement chokes. This is one solution, but seems expensive vs just fixing the log statement?

--- a/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java
+++ b/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java
@@ -95,7 +95,7 @@ public class S3AInputStream extends FSInputStream {
     if (this.pos == pos) {
       return;
     }
-
+    openIfNeeded();
     LOG.info("Reopening " +  wrappedObject.getKey() + " to seek to new offset " + (pos - this.pos));
     reopen(pos);
   }

[thodemoor]

Hi Dan,

Good catch.

S3a is in the works of being merged into Apache Hadoop, see full source f.i. here trunk. This particular issue has been adressed but if you happen to find anything else it would be cool if you also report the issue on the Apache JIRA (dependent on https://issues.apache.org/jira/browse/HADOOP-10400).

[tarnfeld]

I opened a pull request with a fix for this a while back... #6

[dankearns]

Are you not planning to maintain this repo for older hadoop versions?

[thodemoor]

That's up to Jordan (Aloisius) I guess. But hey this is github so you can always fork?