Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Books #1

Merged
merged 8 commits into from May 24, 2022
Merged

Books #1

merged 8 commits into from May 24, 2022

Conversation

Alondra87
Copy link
Owner

@Alondra87 Alondra87 commented May 24, 2022

Description

In this project, We built a basic website that allows users to add/remove books from a list.

Task: https://github.com/microverseinc/curriculum-javascript/blob/main/books/m1_plain_js_objects_v1_1.md

This PR makes the following changes:

  • Sets up the GitHub Actions and the Webhint and Stylelint linters
  • Creates the add/remove books functionality

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (no linters errors)
  • I have checked my code and corrected any misspellings
  • I have commented my code
  • I have deleted any unused code as comments in my codebase

Copy link

@KDlamini KDlamini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team @Alondra87, @gvgesanto2 🙋‍♀️,

Great work! 💯
You have done a great job implementing all the project requirements. 👏🏾
Your feature is complete! There is nothing else to say other than... it's time to merge it. :shipit:
Congratulations!!!

Status: Approved ✔️

giphyapproved

Cheers 🥂 and Happy coding!!! 👯
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @KDlamini in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Alondra87 Alondra87 merged commit 42bdafa into main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants