Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandoned node-zopfli package causes installation failures #11

Closed
4cm4k1 opened this issue Jun 22, 2018 · 3 comments
Closed

Abandoned node-zopfli package causes installation failures #11

4cm4k1 opened this issue Jun 22, 2018 · 3 comments

Comments

@4cm4k1
Copy link

4cm4k1 commented Jun 22, 2018

Due to https://github.com/pierreinglebert/node-zopfli apparently being abandoned and consequently pierreinglebert/node-zopfli#87, it is becoming very difficult to install shrink-ray-current locally or in production without fatal errors.

I've been able to work around this because my cloud hosting provider has the bindings and the compiled binaries cached; however, this is not a long-term solution.

If, with the community's help, we can identify the outstanding issues with the node-zopfli package, I would be willing to create a fork and publish releases via GitHub Releases, so that it stops messing with this package.

Alternatively, I would suggest removing node-zopfli from this package to avoid the installation issue. Given that zopfli is only useful for static assets, it might not be such a big deal for users to remove.

Thoughts?

@Alorel
Copy link
Owner

Alorel commented Jun 22, 2018

I don't know how I feel about removing it. node-zopfli has been causing installation issues starting with Node >=10.0.0 but they can easily be avoided by running npm/yarn install --build-from-source to skip downloading prebuilt bindings.

@4cm4k1
Copy link
Author

4cm4k1 commented Jun 22, 2018

Ah, thanks for that advice, @Alorel! Given the Node v10 note you added in https://github.com/Alorel/shrink-ray/releases/tag/2.1.1, I'm going to close this issue. I wonder if I could somehow make downloading prebuilt bindings work…

@4cm4k1 4cm4k1 closed this as completed Jun 22, 2018
@Alorel
Copy link
Owner

Alorel commented Jun 23, 2018

The native binding api version was bumped in v10 so unless node-zopfli's author comes back and publishes new prebuilt bindings I'm afraid that won't be possible. 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants