Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: because the return value of "net.minecraft.class_1309.getTouchingFluid()" is null at fuzs.puzzleslib.impl.event.FabricEventImplHelper.tickAirSupply(FabricEventImplHelper.java:47) #2

Closed
qq-me opened this issue Oct 27, 2023 · 2 comments

Comments

@qq-me
Copy link

qq-me commented Oct 27, 2023

Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.20.1

Mod Version (Required)

8.1.0 - 8.1.2

Notes (Required)

https://gist.github.com/stunlocked1/599738559e90a6e6a8fc2c68aa6095f8
It kicks player and kills a bunch of other entities because of this thing that mentions puzzle lib. Sometimes it crashes sometimes just hangs. I also downgraded puzzles lib to 8.0.24 and the issue is gone

latest.log (Optional)

https://gist.github.com/stunlocked1/599738559e90a6e6a8fc2c68aa6095f8

@Fuzss
Copy link

Fuzss commented Oct 27, 2023

The crash happens here:

if (getTouchingFluid().getFluid() instanceof StarFluid fluid && fluid.canBreathe((LivingEntity) (Object) this))

Seeing as in all other cases there is a null check included, is a null check being absent here intentional?

@AlphaMode
Copy link
Owner

Fixed 2670140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants