Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Light, My QR Code, Browse buttons in Scan QR Code screen #1495

Closed
colourfreak opened this issue Jul 3, 2020 · 10 comments · Fixed by #1500
Closed

Update Light, My QR Code, Browse buttons in Scan QR Code screen #1495

colourfreak opened this issue Jul 3, 2020 · 10 comments · Fixed by #1500
Assignees

Comments

@colourfreak
Copy link

Current:

2020-07-03 10 18 00

We need:
a) Light - tour on the light in your camera
b) My QR Code - switches to "My Wallet Address" screen
c) Browse - to select images from your Camera Roll

Screenshot 2020-07-03 10 36 30

@JamesSmartCell
Copy link
Member

Hi @ChintanRathod can you complete the controls? Browse may be more tricky to implement; there should be part of the existing QR scanner that parses images though; let's see if we can achieve this without needing additional libraries.

@colourfreak
Copy link
Author

@ChintanRathod You can take a look at how WeChat did this. Their scanner Is very good.

@ChintanRathod
Copy link
Contributor

@ChintanRathod You can take a look at how WeChat did this. Their scanner Is very good.

Sure. I will compare it.

@ChintanRathod
Copy link
Contributor

Hi @ChintanRathod can you complete the controls? Browse may be more tricky to implement; there should be part of the existing QR scanner that parses images though; let's see if we can achieve this without needing additional libraries.

OK. I will check for existing one and implement accordingly

@colourfreak
Copy link
Author

@ChintanRathod Chintan, to make it easier, let's make a version without a "Browse" for now. So only the light and switch to My Wallet Address. Can we release that this week?
https://app.zeplin.io/project/5d088205bff2d15de6a4397b/screen/5f040d37b4215b7cddae21f6/

@colourfreak
Copy link
Author

Screenshot 2020-07-07 at 08 05 06

@ChintanRathod
Copy link
Contributor

@tomekalphawallet Could you please help me to have a "Flash Off" icon? I temporary used from Android Assets but if you can would be great.

@JamesSmartCell
Copy link
Member

Hi @ChintanRathod can you complete the controls? Browse may be more tricky to implement; there should be part of the existing QR scanner that parses images though; let's see if we can achieve this without needing additional libraries.

OK. I will check for existing one and implement accordingly

Let's see if we can use the existing library - not sure how difficult it will be to hook between the code that scans images and the camera image update. Hopefully we can pass the images in the format the scanner likes. Looks like this area of the source would be the useful code - we might be able to pass the image if we can convert to a 'BinaryBitmap':

if (source != null) {
                BinaryBitmap bitmap = new BinaryBitmap(new HybridBinarizer(source));
                try {
                    rawResult = mMultiFormatReader.decodeWithState(bitmap);
                } catch (ReaderException re) {
                    // continue
                } catch (NullPointerException npe) {
                    // This is terrible
                } catch (ArrayIndexOutOfBoundsException aoe) {

                } finally {
                    mMultiFormatReader.reset();
                }

@ChintanRathod
Copy link
Contributor

I have same implementation which converts the Bitmap into BinaryBitmap like below.

image

@colourfreak
Copy link
Author

@tomekalphawallet Could you please help me to have a "Flash Off" icon? I temporary used from Android Assets but if you can would be great.

https://zpl.io/bzg4vg4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants