-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Light, My QR Code, Browse buttons in Scan QR Code screen #1495
Comments
Hi @ChintanRathod can you complete the controls? Browse may be more tricky to implement; there should be part of the existing QR scanner that parses images though; let's see if we can achieve this without needing additional libraries. |
@ChintanRathod You can take a look at how WeChat did this. Their scanner Is very good. |
Sure. I will compare it. |
OK. I will check for existing one and implement accordingly |
@ChintanRathod Chintan, to make it easier, let's make a version without a "Browse" for now. So only the light and switch to My Wallet Address. Can we release that this week? |
@tomekalphawallet Could you please help me to have a "Flash Off" icon? I temporary used from Android Assets but if you can would be great. |
Let's see if we can use the existing library - not sure how difficult it will be to hook between the code that scans images and the camera image update. Hopefully we can pass the images in the format the scanner likes. Looks like this area of the source would be the useful code - we might be able to pass the image if we can convert to a 'BinaryBitmap':
|
|
Current:
We need:
a) Light - tour on the light in your camera
b) My QR Code - switches to "My Wallet Address" screen
c) Browse - to select images from your Camera Roll
The text was updated successfully, but these errors were encountered: