-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model game input #37
Comments
In principle, I agree; however, the width/height need to somehow be bound to a Game instance since we otherwise could create the model with different width/height dimensions than the Game itself. It's also not necessarily always the same for a given game - we could for instance play connect4 with dimensions of 7x9, or 7x5, or whatever like that. If it were the same for a given game, then we could just move it to be a staticmethod / class property, but unfortunately if we want the flexibility we can't do that. If you have any workarounds for this it would be great though, because I agree - instantiating a Game just to pass into the model (and then never be used again) seems silly. |
I agree too. A possible workaround would be to use a dictionnary
|
I think this is a good solution, I can update this |
Currently the model (PhilipNet) needs a game instance as input to get the width/height of the board. I think it's preferable to have width/height as arguments instead, to not have to initialize a game instance every time you want to create a model just to access the width/height, or some other solution. Any thoughts @abhon @charlesoblack ?
The text was updated successfully, but these errors were encountered: