Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce amount of aliasing #10

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Conversation

LumpBloom7
Copy link
Collaborator

@LumpBloom7 LumpBloom7 commented Mar 9, 2020

Changes include:

  • Replacing CircularProgress with CircularContainers (Ring, Cursor)
  • Adding EdgeSmoothness to Boxes (Paddle line, HitNotes)

The paddle seems to be a bit complicated to smooth out, I was thinking of using a long rotating square to mask a CircularContainer, but that may be overstepping my boundaries since that will change how things look. A shader might also do the job, but that seems to be out of my league. (Or maybe there's an obviously simple way to do it and I'm just too dim)

Performance impact is minimal from my testing.

Oh and it's a pleasure to meet ya! I'm Bloom in osu! so hit me up if you're cool with that sort of thing.

Changes include:
* Replacing CircularProgress with CircularContainers (except for the paddle) 
* Adding EdgeSmoothness to Boxes
@naoei naoei added the enhancement New feature or request label Mar 9, 2020
Copy link
Member

@naoei naoei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just tested it and i can't really tell any difference in performance (i might say it improved a little).

good change!

@naoei naoei merged commit 89842dd into taulazer:master Mar 9, 2020
@LumpBloom7 LumpBloom7 deleted the Alias-reduction branch March 18, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants