Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Autoplay functionality #30

Merged
merged 11 commits into from
Mar 18, 2020
Merged

Add Autoplay functionality #30

merged 11 commits into from
Mar 18, 2020

Conversation

MoshiBar
Copy link
Contributor

replays will tend to break at aspect ratios narrower than 4:3

MoshiBar added 3 commits March 17, 2020 09:36
Add Autoplay functionality
92239d7 
replays will tend to break at aspect ratios of narrower than 4:3
CodeFactor fix
b1ca24a
CodeFactor Fix
3f19abb
@bernkastel02 bernkastel02 added the needs tests For when things need tests. label Mar 17, 2020
@naoei
apply osu's code inspection
5af52f7 
eventually we'll need to make the CI analyze the code.
@naoei
Copy link
Member

naoei commented Mar 17, 2020 •
edited
Loading

tested this with a ton of beatmaps and different mods and it seems to work relatively well, though if you can i really wish that you can fix it breaking on an aspect ratio any narrower than 4:3 before merging.

@naoei naoei added enhancement New feature or request and removed needs tests For when things need tests. labels Mar 17, 2020
@MoshiBar
Copy link
Contributor Author

I think the issue comes from the scaling of the playfield. I'll try to see what i can do.
Also right now it always alternates between keys. Do you think it should single tap if the notes are slow enough?

@naoei
Copy link
Member

naoei commented Mar 17, 2020

yeah sure, there's not really much reason for it to alternate if the notes aren't fast

@MoshiBar
Copy link
Contributor Author

so for some reason the replay input is scaling to fit 4:3 aspect ratio while the playfield is scaling to fit 1:1 which causes the inconsistency. Still not sure how to fix it though.

@MoshiBar
Copy link
Contributor Author

Wait, I just realized that made the playfield smaller

@naoei naoei added the needs tests For when things need tests. label Mar 18, 2020
@naoei
Copy link
Member

naoei commented Mar 18, 2020 •
edited
Loading

seems to work well now, but the cursor seems to go out of place on a 0.67:1/4:3 aspect ratio.
image

@naoei naoei removed the needs tests For when things need tests. label Mar 18, 2020
@MoshiBar
Copy link
Contributor Author

Adding the TauPlayfieldAdjustmentContainer also started to break scaling on some things
image
I'm not very experienced with this so I would appreciate any help

@naoei
Copy link
Member

naoei commented Mar 18, 2020

you can change the distance as which the DrawableTauJudgement is placed from the center here:
https://github.com/Altenhh/tau/blob/120c7758bca5e233815d450cd395a3d546638bc9/osu.Game.Rulesets.tau/UI/tauPlayfield.cs#L158

@MoshiBar
Copy link
Contributor Author

thank you. I'll see if i can get it working nicely tomorrow

@naoei
Copy link
Member

naoei commented Mar 18, 2020

works quite well now! 👍

@naoei naoei merged commit 5daa4bb into taulazer:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naoei naoei naoei approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MoshiBar @naoei @bernkastel02