Fix mouse movement not working at certain distances and angles #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this with various ridiculous screen dimensions and scaling options, and have confirmed that it works in all cases. |
|
Can confirm 👍 |
naoei
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
I found the cause to be as follows:
OnMouseMoveonly updates when the cursor is within the drawable boundaries ofDefaultCursor. This is in theory not an issue as the dimensions ofDefaultCursoris equal to the entire screen.However
DefaultCursorrotates itself based on the position of the absolute cursor, causing gaps within the screen which counts as being out of bounds.An override has been made to always assume that the cursor is within bounds.