Metrics "*_last_*_status" return invalid values starting from 2.1.0

[Reuuke]

After upgrading to 2.1.3, we found that the "clickhouse_backup_last_create_status" metric always returns 2 (unknown), regardless of the actual status.
The way I did my test is the following :

$ clickhouse-backup --version
Version:	 2.1.3
Git Commit:	 f3e6a5667371bfa122e5a907b68e5004b40251f7
Build Date:	 2022-12-26

$ curl -s localhost:7171/metrics | grep -E "clickhouse_backup_last_create_status|clickhouse_backup_last_upload_status"
clickhouse_backup_last_create_status 2
clickhouse_backup_last_upload_status 2

$ curl -s localhost:7171/backup/create -X POST
{"status":"acknowledged","operation":"create","backup_name":"2023-01-27T18-58-58"}

$ curl -s localhost:7171/backup/status
{"command":"create","status":"success","start":"2023-01-27 18:58:58","finish":"2023-01-27 18:58:59"}

$ curl -s localhost:7171/backup/upload/2023-01-27T18-58-58
{"status":"acknowledged","operation":"upload","backup_name":"2023-01-27T18-58-58","diff":false}

$ curl -s localhost:7171/backup/status
{"command":"upload 2023-01-27T18-58-58","status":"success","start":"2023-01-27 19:05:23","finish":"2023-01-27 19:07:52"

$ curl -s localhost:7171/metrics | grep -E "clickhouse_backup_last_create_status|clickhouse_backup_last_upload_status"
clickhouse_backup_last_create_status 2
clickhouse_backup_last_upload_status 2

I expected the values to be set to 1 but it stays at 2 after a successful backup and upload.

This metric returns the correct value on versions 1.x.x and 2.0.0, all versions 2.1.x return 2 always.

How you have any idea why? Did I miss something?

[Slach]

Thanks for reporting, try to fix it ASAP
could you check latest master?

[Reuuke]

Yep, checked - the same behavior, value is not updating.

[ppavlov39]

Hi! We also have such a problem and, in addition, the wrong value of the counters of failed and successful backups (always 0).

[Slach]

@ppavlov39 @Reuuke could you check altinity/clickhouse-backup:master docker image?

[ppavlov39]

@Slach Hi!
I just have checked metrics and with the docker images (tag: master) they are correct.