Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api server /backup/kill command is required parameter, not optional #808

Closed
UnamedRus opened this issue Jan 10, 2024 · 0 comments
Closed
Assignees
Milestone

Comments

@UnamedRus
Copy link

https://github.com/Altinity/clickhouse-backup#api

Documentation

Optional query argument command may contain the command name to kill, or if it is omitted then kill the last "in progress" command.

In code

return actionsResults, errors.New("kill <command> parameter empty")

Plus, it seems, it doesn't check that parameter actually named command, just use first parameter value?

@Slach Slach self-assigned this Jan 10, 2024
@Slach Slach added this to the 2.4.17 milestone Jan 10, 2024
@Slach Slach closed this as completed in a33948e Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants