Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Text Area #59

Closed
9 of 10 tasks
Albertlarsen opened this issue Jul 1, 2022 · 4 comments · Fixed by #137
Closed
9 of 10 tasks

Component: Text Area #59

Albertlarsen opened this issue Jul 1, 2022 · 4 comments · Fixed by #137
Assignees
Labels
kind/feature-request New feature or request team/studio up-for-grabs Issues that are easy to fix for new team members or external contributors

Comments

@Albertlarsen
Copy link
Contributor

Albertlarsen commented Jul 1, 2022

Description

Figma

Link to correct placement in our Figma component library.

image

Specification

  • Text area should have a label and it should be possible to add an additional description on several lines under label.
  • It should be possible to add a character count.
  • The width is 100% inside the grid its placed in. It comes in different heights. The height that matches the expected user input should be used.
  • Read-only should as default be plain text, but could be highlighted with an extra css-class for specific cases. See guidelines in Figma.

Design tasks

  • Component is created in Figma
  • All relevant states are created
  • Functionality/animation is described and prototyped
  • The disabled / read-only should be handled equally on all components, find something that works across.

Tokens

  • The size is described with tokens
  • spacing is described with tokens
  • The color of all states are described with tokens
  • Border width or styling is described with tokens
  • Text size are described with tokens
Size
Sets min-height: 
component-textarea-size-min_height-xsmall
component-textarea-size-min_height-small
component-textarea-size-min_height-medium
component-textarea-size-min_height-large
component-textarea-size-min_height-xlarge

-------

Space
Sets padding x and y:
component-textarea-space-padding-x
component-textarea-space-padding-y

-------

Color
Sets border color:
component-textarea-color-border-default
component-textarea-color-border-hover
component-textarea-color-border-disabled
component-textarea-color-border-read-only

Sets background color:
component-textarea-color-background-default
component-textarea-color-background-read-only

Sets text-color:
component-textarea-color-text-default
component-textarea-color-text-disabled


Sets outline color for focus:
interactive_components-colors-focus_outline

-------

Font Size
Sets font-size:
component-textarea-font_size-default

-------

Border width
interactive_components-border_width-normal


-------

Border radius
interactive_components-border_radius-normal



SVG

  • If there are used any svgs in this component is it available for the developer?
@Albertlarsen Albertlarsen changed the title Text field | Commodore Text field component | Commodore Aug 2, 2022
@Albertlarsen Albertlarsen changed the title Text field component | Commodore TextField component | Commodore Aug 2, 2022
@RonnyB71 RonnyB71 added kind/feature-request New feature or request status/draft Status: When you create an issue before you have enough info to properly describe the issue. team/studio labels Aug 9, 2022
@haakemon haakemon changed the title TextField component | Commodore TextField component Aug 9, 2022
@haakemon haakemon changed the title TextField component TextAreacomponent Aug 10, 2022
@haakemon haakemon changed the title TextAreacomponent TextArea component Aug 10, 2022
@mrosvik mrosvik self-assigned this Aug 10, 2022
@RonnyB71 RonnyB71 added the up-for-grabs Issues that are easy to fix for new team members or external contributors label Aug 12, 2022
@mrosvik
Copy link
Member

mrosvik commented Aug 15, 2022

Status: Standard states and types are finished, but the disabled / read-only state may change as we have to handle this equally on all components, and we should find something that works across.

Do we need a larger text area variant with WYSIWYG editor for studio? Should that be a variant of this component or a different component? @haakemon

@haakemon
Copy link
Contributor

Good work on this 😁

Yes, we will need some WYSIWYG editor with markdown support for Studio. I think that should be a separate component.

@FinnurO
Copy link

FinnurO commented Sep 8, 2022

Would this be the time to introduce/include a character count? Altinn/altinn-studio#1116

@mrosvik
Copy link
Member

mrosvik commented Sep 15, 2022

Text area is ready for Review and development.

@mrosvik mrosvik removed their assignment Sep 15, 2022
@haakemon haakemon self-assigned this Sep 29, 2022
@haakemon haakemon removed the status/draft Status: When you create an issue before you have enough info to properly describe the issue. label Sep 29, 2022
@mrosvik mrosvik changed the title TextArea component Component: Text Area Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request New feature or request team/studio up-for-grabs Issues that are easy to fix for new team members or external contributors
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants