Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description and help text on paragraph and title text #5862

Closed
5 tasks done
babsoft2 opened this issue Mar 12, 2021 · 5 comments
Closed
5 tasks done

Description and help text on paragraph and title text #5862

babsoft2 opened this issue Mar 12, 2021 · 5 comments
Assignees
Labels
kind/feature-request Feature request that will be considered. org/nsm Issues relevant for Nasjonal sikkerhetsmyndighet solution/app-frontend The React app frontend for apps developed in Altinn Studio.
Milestone

Comments

@babsoft2
Copy link

babsoft2 commented Mar 12, 2021

In the layout files it should be possible to have description and help text on text:

like:

      {
        "id": "a7725d88-609f-42f9-b8cf-2016aa48895a",
        "type": "header",
        "textResourceBindings": {
          "title": "okonomi1.optionbox.mislighold.label",
          "description": "okonomi1.optionbox.mislighold.desc",
          "help": "okonomi1.optionbox.mislighold.help"
      }

on paragraph also.

Test

  • Help texts on header and paragraph
  • Paragraph and header components without helptext
  • Helptexts on header and paragraph on a smaller screen
  • Screenreader and tabbing to the help texts on header and paragraph
  • Help text icon scale to the text size.
@babsoft2 babsoft2 added the kind/feature-request Feature request that will be considered. label Mar 12, 2021
@lvbachmann
Copy link
Contributor

@lorang92 @nkylstad I believe we decided that title/description for a paragraphs and headers wouldn't make much sense, but adding a help text to either of those components might. Is this something we can add without major changes?

@lvbachmann lvbachmann added the solution/app-frontend The React app frontend for apps developed in Altinn Studio. label Mar 17, 2021
@nkylstad
Copy link
Member

@lorang92 @nkylstad I believe we decided that title/description for a paragraphs and headers wouldn't make much sense, but adding a help text to either of those components might. Is this something we can add without major changes?

Right, f.ex. a header component could be replaced with a paragraph component with markdown to provide similar functionality as a description on a form component.

Adding help texts to text components shouldn't be very complicated, we should be able to just add it without affecting the other components.

@lvbachmann lvbachmann removed their assignment Mar 17, 2021
@lvbachmann
Copy link
Contributor

Adding to current sprint, given that we are running short on front-end tasks.

@lvbachmann lvbachmann added this to the 2021 - W11/12 milestone Mar 17, 2021
@lorang92 lorang92 self-assigned this Mar 23, 2021
@lorang92 lorang92 added the org/nsm Issues relevant for Nasjonal sikkerhetsmyndighet label Mar 23, 2021
@jeevananthank jeevananthank self-assigned this Mar 26, 2021
@jeevananthank
Copy link
Contributor

jeevananthank commented Mar 29, 2021

Test is complete and it is noted that the helptext icon is not scaled or rather not aligned to the bigger texts of header and paragraph components.
header: h2
image.png
paragraph: h1
image.png
app: ttd/frontend-test

@Febakke comments ?

@jeevananthank jeevananthank removed their assignment Mar 29, 2021
@lorang92
Copy link
Contributor

lorang92 commented Apr 7, 2021

Closing issue as done.

@lorang92 lorang92 closed this as completed Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request Feature request that will be considered. org/nsm Issues relevant for Nasjonal sikkerhetsmyndighet solution/app-frontend The React app frontend for apps developed in Altinn Studio.
Projects
None yet
Development

No branches or pull requests

5 participants