Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to remove 'final' in PDFViewController class definition #48

Closed
iBenjamin opened this issue Mar 15, 2017 · 2 comments
Closed

Need to remove 'final' in PDFViewController class definition #48

iBenjamin opened this issue Mar 15, 2017 · 2 comments

Comments

@iBenjamin
Copy link

I need to inherit from PDFViewController to add some custom UIView above vc's view, but i find that PDFViewController can not be inherited. So can you remove the 'final' in the PDFViewController?

@ranunez
Copy link
Collaborator

ranunez commented Mar 16, 2017

This class was intentionally made public and not open for a reason, this isn't a trivial change. I do not want to support this functionality at this time and have to fix the many problems that could arise from subclassing PDFViewController incorrectly, and have to tip toe future modifications to many functions and inadvertently break any subclasses. A much cleaner solution would be to find out what exactly you need, and see if theres a way to reasonably accommodate this without subclassing (one does not need to subclass a view controller to overlay custom views on top of it).

@iBenjamin
Copy link
Author

ok, i understand thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants