Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viran's subtitles don't match the audio pt. 1 (EN) #251

Open
Quintus24 opened this issue Dec 8, 2021 · 5 comments
Open

Viran's subtitles don't match the audio pt. 1 (EN) #251

Quintus24 opened this issue Dec 8, 2021 · 5 comments
Assignees
@AmProsius
Labels
compatibility: easy This issue is easy to make compatible. impl: change obj var This issue requires changing properties of objects. language dependent This issue only occurs in certain localizations. type: session fix The fix for this issues is persistent across a session. validation: required This issue needs validation from one of the validators.
Projects
Fix templates v1.3.0
Milestone
v1.3.0

Comments

@Quintus24
Copy link

Quintus24 commented Dec 8, 2021 •
edited by szapp

Hello, everyone!

I would like to report the following bug:

Describe the bug:
This issue can be encountered in the Swamp Camp if the user starts the "The Swampweed Harvest" quest.
Once the user finishes killing all the Bloodflies, Viran can be heard saying "No more bloodflies to be seen. That was a good job you did!", however, the word "bloodflies" is displayed as "bugs".

Expected behavior:
The subtitles of the conversation with Viran when finishing the quest "The Swampweed Harvest" now match the audio.

Steps to reproduce the issue:

  1. Initiate and progress through the "The Swampweed Harvest" quest.
  2. Talk with Viran and kill all the bloodflies in the vicinity.
  3. Report back to Viran and inform him of your success.
  4. Listen and notice the Audio/Subtitle mismatch.

Additional context
Audio: "No more bloodflies to be seen. That was a good job you did!"
Subtitle: "No more bugs to be seen. That was a good job you did!"

Adding a screenshot for more clear information.
Audio-Subtitle Mismatch Bug

Thank You and Best Regards!
Quintus24
@Quintus24 Quintus24 added the validation: required This issue needs validation from one of the validators. label Dec 8, 2021
@AmProsius AmProsius added compatibility: easy This issue is easy to make compatible. impl: replace assign/push str This issue requires replacing pushed strings or string assignments in the scripts. language dependent This issue only occurs in certain localizations. type: session fix The fix for this issues is persistent across a session. labels Dec 8, 2021
@AmProsius
Copy link
Owner

Note to self: See #91 as reference for the fix.

@szapp
Copy link
Collaborator

szapp commented Dec 9, 2021 •
edited

I think #91 is actually not too related. There, the dialog choice mismatched the output unit (spoken dialog/subtitle). Here, the spoken dialog does not match the subtitle. This requires unfortunately an entirely different approach.

PS: But that's not a bad thing. I was waiting for a bug like this to finally create a "fix-template" for it.

@szapp szapp added compatibility: difficult This issue is difficult to make compatible. and removed type: session fix The fix for this issues is persistent across a session. compatibility: easy This issue is easy to make compatible. impl: replace assign/push str This issue requires replacing pushed strings or string assignments in the scripts. labels Dec 9, 2021
@szapp szapp mentioned this issue Jan 8, 2022
Merged
@szapp szapp added the impl: change obj var This issue requires changing properties of objects. label Jan 8, 2022
@szapp szapp added this to Other in Fix templates Jan 8, 2022
@szapp
Copy link
Collaborator

szapp commented Jan 8, 2022 •
edited

Relevant output unit:

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_NOV_1302_Viran.d

Line 171 in 2892a60

AI_Output (self, hero,"DIA_Viran_Running_07_02"); //No more bugs to be seen. That was a good job you did!

To Do

@szapp szapp changed the title Audio/Subtitle mismatch from NPC "Viran". Viran's subtitles don't match his audio (EN) Jan 8, 2022
@Quintus24
Copy link
Author

Quintus24 commented Jan 8, 2022 •
edited by szapp

Hi @szapp

  • Confirm, if the same issue happens in this dialog line (same dialog when there are still bloodflies around).

You are right! The same issue occurs for that dialogue line as well.

Regards,
Quintus24

@szapp szapp mentioned this issue Jan 10, 2022
Open
@szapp szapp changed the title Viran's subtitles don't match his audio (EN) Viran's subtitles don't match the audio pt. 1 (EN) Jan 10, 2022
@szapp szapp added the type: revert on save The fix for this issue impacts the game and should be reverted when saving. label Jan 10, 2022
@szapp szapp moved this from Other to Dialog: Subtitles in Fix templates Jan 10, 2022
@szapp szapp added compatibility: easy This issue is easy to make compatible. type: session fix The fix for this issues is persistent across a session. and removed type: revert on save The fix for this issue impacts the game and should be reverted when saving. compatibility: difficult This issue is difficult to make compatible. labels Jan 16, 2022
@AmProsius
Copy link
Owner

See #278.

@AmProsius AmProsius self-assigned this Jan 18, 2022
@AmProsius AmProsius added this to To Do in v1.3.0 via automation Jan 18, 2022
@AmProsius AmProsius added this to the v1.3.0 milestone Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmProsius AmProsius

Labels
compatibility: easy This issue is easy to make compatible. impl: change obj var This issue requires changing properties of objects. language dependent This issue only occurs in certain localizations. type: session fix The fix for this issues is persistent across a session. validation: required This issue needs validation from one of the validators.
Projects
Fix templates
Change dialog subtitles
v1.3.0
  
To Do
Milestone
v1.3.0
Development

No branches or pull requests
3 participants
@AmProsius @szapp @Quintus24