Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC uses NPC "Mercenary" dialogue line. #378

Open
Quintus24 opened this issue Feb 17, 2023 · 1 comment
Open

PC uses NPC "Mercenary" dialogue line. #378

Quintus24 opened this issue Feb 17, 2023 · 1 comment
Assignees
Labels
compatibility: difficult This issue is difficult to make compatible. impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. language dependent This issue only occurs in certain localizations. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Milestone

Comments

@Quintus24
Copy link

Hello, everyone!

I would like to report the following bug:

Describe the bug:
This issue can be encountered in the Free Mine by talking with some of the "Mercenary" NPC.
Selecting the "What goes on here in the Camp?" option will trigger the conversation, however, the PC will speak the final dialogue line using the NPC's voice.

Dialogue:
PC: "What goes on here in the Camp?"
NPC: "We guard the entrance to the mine."
PC: "No-one except our people are allowed in."

Expected behavior:
The dialogue output is properly set to its respective owner.

Steps to reproduce the issue:

  1. Travel to the Free Mine and reach the FMC_PATH02 waypoint.
  2. Speak with NPC "Mercenary" and select the "What goes on here in the Camp?" option.
  3. Reach the final dialogue line and notice it is swapped.

Additional context
This issue occurs for all "Mercenary" NPC who share this dialogue option.
Also notice that the string is white instead of yellow.

Attaching screenshots for more clear information.

  1. Location @ FMC_PATH02 waypoint.
    Location @ FMC_PATH02

  2. Initiate Dialogue.
    Select Dialogue Option

  3. PC - Dialogue 1.
    PC - Dialogue 1

  4. NPC - Dialogue 2.
    NPC - Dialogue 2

  5. PC - Dialogue 3.
    PC - Dialogue 3

Thank You and Best Regards!
Quintus24

@Quintus24 Quintus24 added the validation: required This issue needs validation from one of the validators. label Feb 17, 2023
@AmProsius
Copy link
Owner

AmProsius commented Feb 19, 2024

Provided fix:

FUNC VOID Info_Mine_Sld_8_DasLager_Info()
{
AI_Output(other,self,"Info_Mine_Sld_8_DasLager_15_00"); //What goes on here in the Camp?
AI_Output(self,other,"Info_Mine_Sld_8_DasLager_08_01"); //We guard the entrance to the mine.
AI_Output(other,self,"Info_Mine_Sld_8_DasLager_08_02"); //No-one except our people are allowed in.
};

changed to

FUNC VOID Info_Mine_Sld_8_DasLager_Info()
{
    AI_Output(other,self,"Info_Mine_Sld_8_DasLager_15_00"); //What goes on here in the Camp?
    AI_Output(self,other,"Info_Mine_Sld_8_DasLager_08_01"); //We guard the entrance to the mine.
    AI_Output(self,other,"Info_Mine_Sld_8_DasLager_08_02"); //No-one except our people are allowed in.
};

Similar to #142.

@AmProsius AmProsius self-assigned this Feb 19, 2024
@AmProsius AmProsius added this to To Do in v1.3.0 via automation Feb 19, 2024
@AmProsius AmProsius added this to the v1.3.0 milestone Feb 19, 2024
@AmProsius AmProsius added language dependent This issue only occurs in certain localizations. type: session fix The fix for this issues is persistent across a session. compatibility: difficult This issue is difficult to make compatible. validation: validated This issue is still present even with Systempack/Union. provided fix This issue has a fix provided in the comments. impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. and removed validation: required This issue needs validation from one of the validators. labels Feb 19, 2024
@AmProsius AmProsius added this to Change dialog line speaker in Fix templates Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: difficult This issue is difficult to make compatible. impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. language dependent This issue only occurs in certain localizations. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
Fix templates
Change dialog line speaker
v1.3.0
  
To Do
Development

No branches or pull requests

2 participants