Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isidro: Necessary dialog disappearing #388

Open
teo753 opened this issue Nov 11, 2023 · 2 comments
Open

Isidro: Necessary dialog disappearing #388

teo753 opened this issue Nov 11, 2023 · 2 comments
Assignees
Labels
compatibility: easy This issue is easy to make compatible. impl: replace assign int This issue requires replacing integer assignments in the scripts. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Milestone

Comments

@teo753
Copy link

teo753 commented Nov 11, 2023

Describe the bug
When not able to complete Isidro's weed selling quest the first time due to lack of ore, the necessary dialog option does not show up ever again.

Expected behavior
The player should still be able to complete the quest later.

Steps to reproduce the issue

  1. Talk to Baal Isidro in the tavern and agree to sell his weed.
  2. Talk to him again with less than 200 ore in inventory.
  3. Tell him you sold the weed. The player will automatically say that he has less than 200 ore and Isidro will ask him to get it. After this, the dialog option is gone forever and the quest remains unsolved.

Additional context
Ought to be a quick fix, actually very similar to one that was fixed in the very same room: Silas only trading with the player once.

@teo753 teo753 added the validation: required This issue needs validation from one of the validators. label Nov 11, 2023
@AmProsius
Copy link
Owner

Thanks for sharing! We will investigate this further.

@AmProsius
Copy link
Owner

Similar to #30.

Proposed fix:

INSTANCE DIA_BaalIsidro_RUNNING(C_INFO)
{
npc = Nov_1333_BaalIsidro;
nr = 1;
condition = DIA_BaalIsidro_RUNNING_Condition;
information = DIA_BaalIsidro_RUNNING_Info;
permanent = 0;
description = "I've sold the weed. Here's your 200 ore.";
};

changed to

INSTANCE DIA_BaalIsidro_RUNNING(C_INFO)
{
    npc         = Nov_1333_BaalIsidro;
    nr          = 1;
    condition   = DIA_BaalIsidro_RUNNING_Condition;
    information = DIA_BaalIsidro_RUNNING_Info;
    permanent   = 1;
    description = "I've sold the weed. Here's your 200 ore.";
};

@AmProsius AmProsius added type: session fix The fix for this issues is persistent across a session. compatibility: easy This issue is easy to make compatible. validation: validated This issue is still present even with Systempack/Union. provided fix This issue has a fix provided in the comments. impl: replace assign int This issue requires replacing integer assignments in the scripts. and removed validation: required This issue needs validation from one of the validators. labels Feb 19, 2024
@AmProsius AmProsius added this to To Do in v1.3.0 via automation Feb 19, 2024
@AmProsius AmProsius added this to Change item instance variable (int) in Fix templates Feb 19, 2024
@AmProsius AmProsius self-assigned this Feb 19, 2024
@AmProsius AmProsius added this to the v1.3.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy This issue is easy to make compatible. impl: replace assign int This issue requires replacing integer assignments in the scripts. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
Fix templates
Change item instance variable (int)
v1.3.0
  
To Do
Development

No branches or pull requests

2 participants