Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troublesome 'package.json' access at runtime in frozen applications #152

Closed
malversoft opened this issue Sep 1, 2020 · 3 comments
Closed

Comments

@malversoft
Copy link

When using a Python frozen module (for example building an executable with PyInstaller), by default the builder only includes the Python bytecodes. So only that bytecodes are available when the module is imported at runtime.

But the JumpSSH package unconditionally reads the package.json file at runtime, just to get the package version.

For this reason JumpSSH can never be used as-is in a frozen Python executable. It requires to dive into the frozen applications builder and create specific hooks to include all JumpSSH files.

It would be a great help if the package simply specifies the version value in the code, so no data files are needed at runtime:
__version__ = "1.6.4"

Thanks in advance. And thanks for your good work.

@t-cas
Copy link
Contributor

t-cas commented Sep 2, 2020

Hi @malversoft,

I fully agree with you, this design has been done few years ago and I think having version in python file would save some issues like yours.

@securenotebook
Copy link

Was banging my head against a wall for two days on this one.

Great app, please let me when you resolve. In the meantime is there any manual workarounds?

@t-cas
Copy link
Contributor

t-cas commented Nov 6, 2020

delivered in #167 and is part of jumpssh release 1.6.5

@t-cas t-cas closed this as completed Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants