Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom brew duration #7

Open
Aman7123 opened this issue Jan 21, 2023 · 0 comments
Open

Allow custom brew duration #7

Aman7123 opened this issue Jan 21, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Aman7123
Copy link
Owner

This coffee pot does not allow adjusting the length of brew, it works until all the water is boiled and gone.

This ticket is to open the idea of allowing the BREW_CYCLE_TIMEOUT field to be instantiated in the main ESP8266-Coffee-Pot.ino file as an integer and allowing both POST and PATCH to update the value.

I do believe this ticket will require a rework to the brewTimeout internal variable which determines when to stop a brew and is calculated on startup, this system could move to storing the time of initial brew then constantly checking if:

systemClock > (brewInitiationTime + brewCycleLength)
@Aman7123 Aman7123 added the enhancement New feature or request label Jan 21, 2023
@Aman7123 Aman7123 self-assigned this Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant