Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework English strings #260

Merged
merged 10 commits into from Aug 17, 2021
Merged

Rework English strings #260

merged 10 commits into from Aug 17, 2021

Conversation

alissonlauffer
Copy link
Member

@alissonlauffer alissonlauffer commented May 15, 2021

The purpose of this pull request is to track the upcoming changes to strings to make them more consistent and better:

  • Remove trailing whitespaces from line start and end of lines.
  • Remove emojis from non keyboard strings, since we don't use emojis there (With some exceptions).
  • Remove ( ) from help strings (E.g.: /setwarnsaction (ban/mute/kick)), since that may lead the user to wrongly use them.
  • Remove trailing whitespaces before punctuation characters.
  • Add punctuation at the end of some strings.
  • "Rewrite" strings and fix grammar issues using a spell checker.
  • Rename string keys with more meaningful and short names.
  • Other misc changes.

Any additional suggestions are welcome.

Copy link
Contributor

@alissonlauffer Hmm

@AndrielFR
Copy link
Member

Thanks Alisson. 🙏🤝

@iiiiii1wepfj
Copy link
Contributor

good

@alissonlauffer alissonlauffer force-pushed the strings-fixes branch 2 times, most recently from 9124955 to eafd9aa Compare July 25, 2021 21:19
@alissonlauffer alissonlauffer marked this pull request as ready for review August 17, 2021 17:21
@alissonlauffer alissonlauffer merged commit 4dd5266 into main Aug 17, 2021
@alissonlauffer alissonlauffer deleted the strings-fixes branch August 17, 2021 17:22
alissonlauffer added a commit that referenced this pull request Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants