Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug with link in code #9

Closed
marmotz opened this issue Jan 6, 2013 · 3 comments
Closed

bug with link in code #9

marmotz opened this issue Jan 6, 2013 · 3 comments

Comments

@marmotz
Copy link
Contributor

marmotz commented Jan 6, 2013

source:

[[[shell
curl https://raw.github.com/atoum/atoum-installer/master/installer | php -- --phar
php mageekguy.atoum.phar -v
atoum version nightly-xxxx-yyyymmddhhmm by Frédéric Hardy (phar:///path/to/mageekguy.atoum.phar)
]]]

generated:

<pre class="shell">curl https://raw.github.com/atoum/atoum-installer/master/installer | php -- --phar
php mageekguy.atoum.phar -v
atoum version nightly-xxxx-yyyymmddhhmm by Frédéric Hardy ([[phar:///path/to/mageekguy.atoum.phar)]]</pre>

expected:

<pre class="shell">curl https://raw.github.com/atoum/atoum-installer/master/installer | php -- --phar
php mageekguy.atoum.phar -v
atoum version nightly-xxxx-yyyymmddhhmm by Frédéric Hardy (phar:///path/to/mageekguy.atoum.phar)</pre>

(phar link was converted to a skriv link but shouldn't)

@Amaury
Copy link
Owner

Amaury commented Jan 6, 2013

Interresting. In fact, there is a piece of code, activated before WikiRenderer, which goals is to transform "free-links" in marked-up links.

For example, http://skriv.org become [[http://skriv.org]], and in the end <a href="http://skriv.org">http://skriv.org</a>.

But this code is a little too aggressive. It transform anything that contains :// (it's a little bit more complex; take a look at \Skriv\Markup\Html\Config::onStart() to see the regular expression). More, its behaviour interfere with the image markup interpretation.

I will change that quickly.

@Amaury
Copy link
Owner

Amaury commented Jan 6, 2013

Second-thought... In fact, even if the pre-parser is too aggressive, the Code markup should prevent any interpretation inside its block. So, I have to completely re-think how it works...

@Amaury
Copy link
Owner

Amaury commented Jan 7, 2013

The last commit correct this issue. You must update SkrivMarkup and WikiRenderer.

@Amaury Amaury closed this as completed Jan 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants