Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating ad slots: try to verify the website, show issues #394

Closed
Ivshti opened this issue Mar 9, 2020 · 0 comments · Fixed by #407
Closed

creating ad slots: try to verify the website, show issues #394

Ivshti opened this issue Mar 9, 2020 · 0 comments · Fixed by #407
Assignees
Milestone

Comments

@Ivshti
Copy link
Member

Ivshti commented Mar 9, 2020

Is your feature request related to a problem? Please describe.
It's related to this: AmbireTech/adex-market#86

When creating an ad slot, we need to run the verification on the market and display issues, if any.

Related market task: AmbireTech/adex-market#86

Describe the solution you'd like
When creating an ad slot, if it fails, show the reason and the way to solve it (DNS TXT + link to the tutorial). Then, allow to re-try once you add the record.

We'll prioritize DNS TXT verification since it's the most accurate/reliable and works around multiple issues of verifying the integration code.

Also, enforce that the website protocol is https:

If successful, show a message "verification is successful" and stop displaying the "verfiication required" banner on the dashboard

@Ivshti Ivshti added this to the v4.1 milestone Mar 9, 2020
@Ivshti Ivshti changed the title creating ad slots: try to verify the website creating ad slots: try to verify the website, show issues Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants