Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator messages pruning logic #89

Closed
6 tasks
Ivshti opened this issue Mar 25, 2019 · 0 comments · Fixed by #165
Closed
6 tasks

Validator messages pruning logic #89

Ivshti opened this issue Mar 25, 2019 · 0 comments · Fixed by #165
Assignees

Comments

@Ivshti
Copy link
Member

Ivshti commented Mar 25, 2019

It should work like this:

  • drop Heartbeats that are older than a threshold
  • drop Accounting messages that are older than a threshold; can always be replayed via eventAggrs
  • drop NewState/ApproveState older than a threshold, except ones with the stateRoot of the lastApproved (to ensure we can't drop our last approved pair)

see below


after a few discussions with @samparsky, it would be sufficient to:

  • drop Heartbeats that are older than threshold
  • drop all validator messages for expired channels (channel.validUntil); this can be done via an additional prune script
  • add a maximum channel validity that's accepted (ethereum adapter); should be 1 year

(re accounting messages: removing them is extremely dangerous, since if we remove the last available one, then everything is practically broken cause accounting will start from 0)

@Ivshti Ivshti added this to the v0.5 milestone Mar 25, 2019
@Ivshti Ivshti pinned this issue May 17, 2019
@Ivshti Ivshti modified the milestones: v0.5, v0.6 May 26, 2019
@Ivshti Ivshti modified the milestones: v0.6, v0.7 May 26, 2019
@samparsky samparsky mentioned this issue May 29, 2019
3 tasks
@Ivshti Ivshti unpinned this issue Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants