Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEL /enrollments - 'Enrollment/s Not Found' is missing #208

Open
AleksandrMolchagin opened this issue May 30, 2024 · 0 comments
Open

DEL /enrollments - 'Enrollment/s Not Found' is missing #208

AleksandrMolchagin opened this issue May 30, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AleksandrMolchagin
Copy link
Member

AleksandrMolchagin commented May 30, 2024

Description:

The DEL /enrollments method currently returns Enrollment/s deleted successfully even when no records are found.

Expected Behavior:

When no records are found, the API should return a 404 status code with the following response body:

404: 
  body:
    application/json:
      example:
        message: Enrollment/s Not Found    

When some enrollments are found and deleted while others are not found, the API should return a 206 status code with the following response body:

{
  "message": "Partial Success",
  "deleted": ["enrollment_id_1", "enrollment_id_2"],
  "not_found": ["enrollment_id_3", "enrollment_id_4"]
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants