Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow Report description/range not depicted in reports #223

Open
AWKevin opened this issue Jul 22, 2021 · 5 comments
Open

Flow Report description/range not depicted in reports #223

AWKevin opened this issue Jul 22, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@AWKevin
Copy link

AWKevin commented Jul 22, 2021

ON TESTFLIGHT: I went to the Upper Middle Fork flathead and added a flow report, with a date, no caption, a photo, a gage observation, and I "Describe the Flow" as High Runnable. When I view the Report I expected to see the "High Runnable" noted under "Flow Range:" but instead I see "No Visual Reported."
IMG_4A6479ABFBBA-1

@AWKevin AWKevin added the bug Something isn't working label Jul 22, 2021
@AWKevin AWKevin added this to To do in iOS App Enhancements Jul 22, 2021
@Gregliest
Copy link
Contributor

Is this different than #193?

@AWKevin
Copy link
Author

AWKevin commented Jul 22, 2021

Ah, right, ha ha sorry about the duplicate. It is the same issue with maybe a new insight. Could likely close this one. The key point here is that there is no home for the "Runnable" etc picker in the flow report form. And there is no way to fill the "Flow Range" field on the Report. Perhaps the intention here is to wire up these input and output fields to fill/show the field.

@Gregliest
Copy link
Contributor

@yeahphil Does your work on the flow reports page fix this?

@yeahphil
Copy link
Collaborator

Lol it breaks it in a new way :)
image

@yeahphil
Copy link
Collaborator

The issue here is that the query we're doing doesn't return the observation value that was posted.

We posted it as observation when saving. The query we're using doesn't return that. @ryangroth5 can you shed any light on how to get it back? And also, can I view these observations on the web somehow to see what actually got saved?

Here's the GraphQL query that's getting observations in case that's helpful:

query Observations2($page_size: Int!, $reach_id: AWID!, $page: Int!,  $post_types: [PostType])
{
    posts(post_types: $post_types, reach_id: $reach_id, first: $page_size, page: $page, orderBy: [{field: REVISION, order: ASC}]) {
        paginatorInfo {
            lastPage,
            currentPage,
            total,
        },
        data {
            id,
            title,
            detail,
            uid,
            user {
                uname,
            }
            post_date,
            post_type,
            revision,
            reach {
                id,
                river,
                section
            },
            reach_id,
            gauge_id,
            metric_id,
            metric {
                shortkey,
                unit,
                name
            },
            reading,
            photos {
                id,
                post_id,
                photo_date,
                image {
                    ext,
                    uri {
                        thumb,
                        medium,
                        big
                    }
                }
            }
        }
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

3 participants