Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query new gauges API in all remaining places where flows are displayed #588

Open
2 of 4 tasks
ngottlieb opened this issue Mar 27, 2024 · 7 comments
Open
2 of 4 tasks
Assignees

Comments

@ngottlieb
Copy link
Contributor

ngottlieb commented Mar 27, 2024

  • add new flow queries for the reach map table component
  • add new flow queries for state table component
  • update reach beta box to query new flow API
  • update flow tab chart to read data from new API
@ngottlieb
Copy link
Contributor Author

beta box changes incorporated into #591

@ngottlieb
Copy link
Contributor Author

flow tab changes incorporated into #591

@ngottlieb
Copy link
Contributor Author

The existing state lists, it turns out, are still Laravel-based – e.g. https://www.americanwhitewater.org/content/River/state-summary/?state=AK. I don't think it makes sense to make changes to the Laravel code-base to incorporate retrieving data from the new gauge API, which leaves us with two options:

  1. launch new gauge system without a state-by-state table
  2. re-write the state by state table in the Vue app

Any thoughts @AWKevin @tallowen ?

@tallowen
Copy link
Member

tallowen commented May 7, 2024

I think if it's not too much work, getting the state-by-state tab into vue makes sense to me.

@ngottlieb
Copy link
Contributor Author

ngottlieb commented May 7, 2024

I think if it's not too much work, getting the state-by-state tab into vue makes sense to me.

does an API already exist to support this? I'll look but you may know off the top of your head if the mobile app is doing something similar. I would need: query reaches by state and include correlation details with the response @tallowen

@tallowen
Copy link
Member

tallowen commented May 7, 2024

@ngottlieb - we don't have that API yet - the mobile app does all of it's sorting/filtering client side after it already has all of the information right now.

@ngottlieb
Copy link
Contributor Author

state table work is functional, merged into #591 via #593. It will continue to be updated when new APIs are available from @tallowen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants