Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

questions on _process_data(), _get_observation() and multi symbols #11

Closed
yglpyn8888 opened this issue Dec 8, 2021 · 2 comments
Closed

Comments

@yglpyn8888
Copy link

1 The _process_data() method takes the return value of _get_prices() as a feature, but the return value of _get_prices() is two columns of bar data which are close and open, and this are not features. Why?
2 _get_observation() returns a dict, but not a np.ndarray, for a typicle gym env, Shouldn't the observation returned by the step method be a np.ndarray?
3 I see many data structures in this framework use Dict, which should be to support multiple symbols? I only load data of a single symbol, so should I change the underlying data structure,? or just put a single key (the single symbol i focus on) in the dict.

@yglpyn8888
Copy link
Author

for question1 , i thought i understand that you just collect close and open as two features as an example, and i can override this method to load other feature columns what i want

@AminHP
Copy link
Owner

AminHP commented Dec 10, 2021

  1. It should return Dict when the observation_space is an instance of spaces.Dict.
  2. There is no need to change the structure. Just put a single key for the symbol you want. And make sure simulator.unit is in symbol_info.currencies for that symbol.

@AminHP AminHP closed this as completed Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants