Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hebrew Rendering #12

Closed
uriee opened this issue Jun 12, 2019 · 5 comments
Closed

Hebrew Rendering #12

uriee opened this issue Jun 12, 2019 · 5 comments

Comments

@uriee
Copy link

uriee commented Jun 12, 2019

Helllo,

When i try to render hebrew charecters i get these kind of charecters : ×ורי
i had cloned the ptoject on a windows machine that has all the font installed.

is there a way to fix it?

Thanks.

@AmirTugi
Copy link
Owner

Hey!
Can you please provide me with the code you're trying to run (and maybe some environment info)?
I've had no issues with any language - it's Puppeteer which renders the HTML. So if the browser knows how to render it correctly, the lib should render it correctly as well.

@uriee
Copy link
Author

uriee commented Jun 13, 2019

Hello Amir, thank you for your replay.
after some manual debugging i managed to preserve the Hebrew using puppeteer's
page.setContent
instead of
page.goto('data:text/html'...

@uriee uriee closed this as completed Jun 16, 2019
@AmirTugi AmirTugi mentioned this issue Jun 16, 2019
@oneEyedSunday
Copy link

oneEyedSunday commented Jun 17, 2019

@uriee I'm doing sth like this

    format: 'A4',
    printBackground: true
  };

  const teaSchoolOptions = {
    styleOptions,
    htmlTemplatePath,
    htmlTemplateOptions: data,
    pdfOptions
  };

  // We just wait for the pdf to generate, and then the program can exit
  return TeaSchool.generatePdf(teaSchoolOptions);

I don't access page as in your fix.

Edit:
I just went through the source and saw that. Did you make a fork of the project to access page?

@uriee
Copy link
Author

uriee commented Jun 17, 2019

@oneEyedSunday I did'nt fork it i just used some concepts introduced in this repo in my code.

@oneEyedSunday
Copy link

thanks. i've made necessary adjustments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants