Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

result should execute defaultValue if it's a function. #32

Closed
jdalton opened this issue Dec 19, 2014 · 4 comments
Closed

result should execute defaultValue if it's a function. #32

jdalton opened this issue Dec 19, 2014 · 4 comments
Labels
bugs

Comments

@jdalton
Copy link

jdalton commented Dec 19, 2014

result should execute defaultValue if it's a function.
@bear bear added the bugs label Dec 19, 2014
@jdalton
Copy link
Author

jdalton commented Jan 5, 2015

Wouldn't this be a back compat breaking change?

@HenrikJoreteg
Copy link
Member

I just talked this over with @latentflip, I think the most sane approach in dealing with this is to say the tests are the version contract. if we have to change a test, it's major.

@HenrikJoreteg
Copy link
Member

it could go any of three ways and it hasn't been published it yet.

@jdalton
Copy link
Author

jdalton commented Jan 5, 2015

So it favors having poor test coverage?

@jdalton jdalton mentioned this issue Jan 8, 2015
Closed
@HenrikJoreteg HenrikJoreteg mentioned this issue Jan 13, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bear @jdalton @HenrikJoreteg