Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't set date properties to null #24

Closed
zweinz opened this issue Jul 4, 2014 · 2 comments
Closed

Can't set date properties to null #24

zweinz opened this issue Jul 4, 2014 · 2 comments
Labels
bug

Comments

@zweinz
Copy link
Contributor

zweinz commented Jul 4, 2014

Even with required = false / allowNull = true, the setter turns them into NaN, which throws an error.
@zweinz zweinz mentioned this issue Jul 7, 2014
Merged
@zweinz zweinz closed this as completed Jul 7, 2014
@wraithgar
Copy link
Contributor

This had to be reverted after discussion in irc.

@wraithgar wraithgar reopened this Aug 17, 2014
@HenrikJoreteg
Copy link
Member

I raised some questions because this might be an issue with other types as well, it seems we should simply be able to use the allowNull option. The PR doesn't reference that option, just always allows null for dates, which may not be desirable in other circumstances.

@wraithgar wraithgar mentioned this issue Sep 16, 2014
Closed
@bear bear added the bug label Oct 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bear @wraithgar @HenrikJoreteg @zweinz