-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing serialize() and toJSON() options. #9
Comments
+1 |
What's the use-case @ConneXNL? Subcollections are intended to be a proxy to a collection for filtering, sorting and paging purposes—a view collection, if you will. The serialize() and toJSON() methods are usually used for persistence purposes. |
As subcollection is intended to at least mostly mimic and behave like a collection, it makes sense to me to add these methods. Especially if these folks have a use case. |
@AmpersandJS/owners, @AmpersandJS/community-leaders, and @ConneXNL: I'm planning to submit a PR soon that will address public API parity with &-collection. Kamil and Philip, I'll be addressing event bubbling too. |
Moving this to appropriate repos |
I think the subcollections should really cover serialize() and toJSON().
What is the best way to implement it? I currently copied over the serialize() and toJSON() from ampersand-collection.
The text was updated successfully, but these errors were encountered: