Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing serialize() and toJSON() options. #9

Closed
jrmyio opened this issue Aug 14, 2014 · 5 comments
Closed

Missing serialize() and toJSON() options. #9

jrmyio opened this issue Aug 14, 2014 · 5 comments

Comments

@jrmyio
Copy link
Contributor

jrmyio commented Aug 14, 2014

I think the subcollections should really cover serialize() and toJSON().

What is the best way to implement it? I currently copied over the serialize() and toJSON() from ampersand-collection.

@bear bear added the question label Oct 31, 2014
@ivan-kleshnin
Copy link

+1

@aaronmccall
Copy link

What's the use-case @ConneXNL? Subcollections are intended to be a proxy to a collection for filtering, sorting and paging purposes—a view collection, if you will. The serialize() and toJSON() methods are usually used for persistence purposes.

@bear bear added the triage label Dec 8, 2014
@HenrikJoreteg
Copy link
Member

As subcollection is intended to at least mostly mimic and behave like a collection, it makes sense to me to add these methods. Especially if these folks have a use case.

@bear bear removed the triage label Dec 8, 2014
@aaronmccall
Copy link

@AmpersandJS/owners, @AmpersandJS/community-leaders, and @ConneXNL: I'm planning to submit a PR soon that will address public API parity with &-collection. Kamil and Philip, I'll be addressing event bubbling too.

@wraithgar
Copy link
Contributor

Moving this to appropriate repos

@bear bear removed the question label Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants