Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository pattern defining and usage #1

Closed
Ahmad-Hamwi opened this issue Oct 29, 2022 · 1 comment
Closed

Repository pattern defining and usage #1

Ahmad-Hamwi opened this issue Oct 29, 2022 · 1 comment
Assignees

Comments

@Ahmad-Hamwi
Copy link

Hi Amr, I have noticed that you have your repository implementation is defined in you domain layer, and the class MainRepositoryImpl is referencing everything from the data layer. I Believe that its correct place is at the data layer.

Also, I have noticed that you are trying to inject the implementation directly. You can inject the interface, and let Hilt inject you implementation at runtime.

@Amrjyniat Amrjyniat self-assigned this Nov 3, 2022
@Amrjyniat
Copy link
Owner

Hi Ahmad, sorry for the late response.
You're right, I'll fix it soon, Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants