Honor supports_http_options: false by dropping them when found #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcg1969
force-pushed
the
no-http-options
branch
from
47cc170
to
8fcdf7f
Compare
mcg1969
force-pushed
the
no-http-options
branch
3 times, most recently
from
a78f64c
to
f50d638
Compare
mcg1969
force-pushed
the
no-http-options
branch
from
f50d638
to
dc0cbac
Compare
mcg1969
force-pushed
the
no-http-options
branch
3 times, most recently
from
a9c2e29
to
569de88
Compare
mcg1969
force-pushed
the
no-http-options
branch
from
569de88
to
fcda73e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As currently implemented, the
supports_http_optionsflag has no useful impact.For notebooks and bokeh apps,
supports_http_optionsdefaults totrue, which allows the code to translate these options to a form that these types of applications can understand. Overriding this default, and settingsupports_http_optionstofalse, would break both of these apps. It would be better therefore if this option is not available for these cases.On the other hand, for scripts (e.g.,
windowsandunix), the flag has no effect whatsoever. If the HTTP options are passed to ananaconda-project runcommand, they are passed through unchanged, no matter what the value of this setting is.This simple PR solves the second case, but not the first. It causes
anaconda-projectto properly respect ansupports_http_options: falsesetting for scripts, by stripping those options out before constructing the full shell command..