Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow packages key #200

Merged
merged 5 commits into from
Jun 18, 2019
Merged

Allow packages key #200

merged 5 commits into from
Jun 18, 2019

Conversation

cjmartian
Copy link

Allows for the use of 'packages' as an alias for 'dependencies' as requested here:
#194

@cjmartian
Copy link
Author

cjmartian commented Jun 7, 2019

Just ran python scripts/run_tests.py locally on my mac:
anaconda_project/requirements_registry/providers/test/test_conda_env.py::test_prepare_and_unprepare_project_scoped_env PASSED
python --version Python 3.7.3

The travis-ci failure is on mac build target 3.7

@mcg1969
Copy link
Collaborator

mcg1969 commented Jun 9, 2019

@cjmartian, sorry this took so long to look at but I have some bad news—this isn't actually what was asked for in #194. What that issue is requesting is for the syntax for anaconda-project.yml itself to be altered, so that dependencies: can be freely used wherever packages: is currently expected. To see what this means, take a look at this file, referred to in #194:

https://github.com/pyviz-topics/examples/blob/master/bay_trimesh/anaconda-project.yml

Note the use of dependencies:, but also this &deps/*deps trick.

@cjmartian
Copy link
Author

cjmartian commented Jun 10, 2019

@mcg1969 This branch should have been named allow-dependencies-key sorry about that.

I tested that I can still run anaconda-project run with an anaconda-project.yml from the examples directory that has the key dependencies rather than packages and it seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants