Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autogenerate default env #232

Merged
merged 4 commits into from
Oct 24, 2019
Merged

Conversation

AlbertDeFusco
Copy link
Collaborator

This allows the simplest anaconda-project.yml file to be utilized without an env_specs key.

name: My project

packages:
  - python=3.7
  - notebook
channels: []

on anaconda-project prepare it will infer that the name of the env_spec is default.

@AlbertDeFusco
Copy link
Collaborator Author

This also works on environment.yml-like files. This PR could be extended to just assume the environment.yml file is the anaconda-project.yml. Anyone have strong opinions here?

name: no_envs
dependencies:
  - python=3.7
  - requests

@jbednar
Copy link
Collaborator

jbednar commented Oct 16, 2019

I'm not sure of the precise thing you are proposing, but it sounds in line with my own opinion that there shouldn't be any major distinctions between an environment.yml file and an anaconda-project.yml file; as far as environments are concerned they should be made to be interchangeable.

@mcg1969
Copy link
Collaborator

mcg1969 commented Oct 17, 2019

I am all for this. I would definitely support interpreting environment.yml files this way if there is no anaconda-project.yml file in the same directory.

@mcg1969
Copy link
Collaborator

mcg1969 commented Oct 24, 2019

@AlbertDeFusco this is passing. We can get this in now if you like, and handle the environment.yml case separately.

@AlbertDeFusco
Copy link
Collaborator Author

certainly

@mcg1969 mcg1969 merged commit 58601b8 into anaconda:master Oct 24, 2019
@mcg1969 mcg1969 mentioned this pull request Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants