-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix prepare action when using global "dependencies:" #245
Conversation
Is the issue that "dependencies" is accepted for some things, like "anaconda-project run", but not others, like "anaconda-project prepare"? If so, looks good! |
Yes, the key is accepted, but won't do the right thing with either name: test-deps
dependencies:
- python=3.7
commands:
version:
unix: python -c 'import sys;print(sys.version)'
|
D'oh! For some time now we've been using anaconda-project.yml files where packages and dependencies are aliased to each other so they are usable in every context, so it's possible we wouldn't have noticed problems with it. But I'm still very confused how this behavior could have been broken, as it looks like "dependencies" was the name originally used (#200), so any older .yml file would no longer have worked? It's hard to see how any tests are passing or old projects are working. |
In any case yes, I can verify that the incorrect Python version (3.8) is installed with the given .yml file, and that Python 3.7 is installed when "dependencies" is changed to "packages". |
I caught a problem where running
anaconda-project prepare
on the following spec would install a Python 3.8 environment. This happened because whiledependencies:
was an allowed key it was ignored.This PR also adds a test that will fail on the master branch.