Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conda 4.4+ support (conda not on path errors) #75

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tjd2002
Copy link

@tjd2002 tjd2002 commented May 30, 2018

Uses the $CONDA_EXE environment variable to find conda, rather than assuming it's on the path. Inspired by (and fixes the same problems as: anaconda/nb_conda_kernels#79 )

Also adds Travis testing for new- and old-style installs (borrowing from: anaconda/nb_conda_kernels#82 and anaconda/nb_conda_kernels#83)

Discussion of 4.4+ support across all nb extensions at: https://github.com/Anaconda-Platform/anaconda-nb-extensions/issues/168

Fixes conda>=4.4 installs where conda is not on the path.
uses conda shell script instead of adding conda on path. Also fixes flake8 error in a test
@tjd2002
Copy link
Author

tjd2002 commented May 30, 2018

@mcg1969 @benbovy could you take a look?

@tjd2002
Copy link
Author

tjd2002 commented May 30, 2018

(This also incorporates #74 to get tests passing again)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 45.477% when pulling 65cda30 on tjd2002:conda44-fix into c27196f on Anaconda-Platform:master.

@coveralls
Copy link

coveralls commented May 30, 2018

Coverage Status

Coverage decreased (-0.2%) to 45.477% when pulling b1f2498 on tjd2002:conda44-fix into c27196f on Anaconda-Platform:master.

@tjd2002
Copy link
Author

tjd2002 commented May 30, 2018

Added @voidworker's fix from #66, which handles new behavior of conda info --json since 4.4

@elgalu
Copy link

elgalu commented Sep 3, 2018

Hi @tjd2002 how is your fork doing?

Given this project doesn't seem maintained I was thinking about switching to your branch but maybe you faced new issues and no longer using nb_conda ?

@BharatKambalur
Copy link

Has there been any progress merging this in?

@tjd2002
Copy link
Author

tjd2002 commented Dec 11, 2018

I would like to see this merged, but I don't use the conda tab anymore. (I think that Anaconda Navigator is the recommended way to manage conda envs if you need a GUI).

Note that you can still use conda kernels with Jupyter by installing the nb_conda_kernels package.

@tjd2002
Copy link
Author

tjd2002 commented Dec 11, 2018

@mcg1969 Any interest in pushing this forward?

@tjd2002
Copy link
Author

tjd2002 commented Nov 9, 2019

This repo seems to be quite soundly dead but there's an actively-developed fork at : https://github.com/fcollonval/jupyter_conda (Thanks @fcollonval)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants