Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS bundling / refactoring (SASS plugin?) #28

Open
1 of 8 tasks
thescientist13 opened this issue Nov 9, 2021 · 1 comment · May be fixed by #15 or #56
Open
1 of 8 tasks

CSS bundling / refactoring (SASS plugin?) #28

thescientist13 opened this issue Nov 9, 2021 · 1 comment · May be fixed by #15 or #56
Assignees
@thescientist13
Labels
chore question Further information is requested
Projects
Jamstack Migration - Phase 1 Jamstack Migration - Phase 2
Milestone
Jamstack Migration

Comments

@thescientist13
Copy link
Contributor

thescientist13 commented Nov 9, 2021 •
edited by aimeelramirez

Type of Change

  • New Feature Request
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Currently just to get things through in #17 , compiling SASS was bypassed (see #15 ) inn favor of getting things through. As a result, full bundles of bootstrap.css and font-awesome.css are bundled into every WC, which is definitely not ideal.

Details

As part of ProjectEvergreen/greenwood#763 would like to evaluate ways to improve this
@thescientist13 thescientist13 added question Further information is requested chore labels Nov 9, 2021
@thescientist13 thescientist13 added this to the Jamstack Migration milestone Nov 9, 2021
@thescientist13 thescientist13 self-assigned this Nov 9, 2021
This was referenced Nov 9, 2021
Merged
Closed
@thescientist13 thescientist13 linked a pull request Nov 17, 2021 that will close this issue
Poc/sass plugin bootstrap #15
Draft
3 tasks
@thescientist13 thescientist13 linked a pull request Nov 17, 2021 that will close this issue
Draft
3 tasks
@thescientist13 thescientist13 moved this from TODO to IN PROGRESS in Jamstack Migration - Phase 1 Nov 17, 2021
@thescientist13 thescientist13 moved this from IN PROGRESS to TODO in Jamstack Migration - Phase 1 Nov 17, 2021
@thescientist13 thescientist13 moved this from TODO to IN PROGRESS in Jamstack Migration - Phase 1 Nov 20, 2021
@thescientist13 thescientist13 moved this from IN PROGRESS to TODO in Jamstack Migration - Phase 1 Dec 4, 2021
@thescientist13
Copy link
Contributor Author

Don't need font awesome for everything?

@thescientist13 thescientist13 moved this from TODO to IN PROGRESS in Jamstack Migration - Phase 1 Dec 9, 2021
@thescientist13 thescientist13 linked a pull request Dec 9, 2021 that will close this issue
Draft
3 tasks
@thescientist13 thescientist13 linked a pull request Dec 9, 2021 that will close this issue
deduped CSS and refactored to not use Shadow DOM #56
Draft
3 tasks
@thescientist13 thescientist13 moved this from TODO to IN PROGRESS in Jamstack Migration - Phase 2 Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
chore question Further information is requested
Projects
Jamstack Migration - Phase 2
IN PROGRESS
Jamstack Migration - Phase 1
IN PROGRESS
Milestone
Jamstack Migration
1 participant
@thescientist13