Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CESIUM_RTC to the feature table for b3dm #263

Closed
lilleyse opened this issue Oct 3, 2017 · 8 comments
Closed

Move CESIUM_RTC to the feature table for b3dm #263

lilleyse opened this issue Oct 3, 2017 · 8 comments

Comments

@lilleyse
Copy link
Contributor

lilleyse commented Oct 3, 2017

Now that b3dm tiles have a feature table, it would probably make sense for RTC_CENTER to exist in the feature table. It's still worth supporting CESIUM_RTC as a glTF extension, but the feature table RTC_CENTER seems preferable from a spec point of view.

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 5, 2017

Would this eliminate the need for the CESIUM_RTC extension? Can you draft up a quick schema example?

@pjcozzi
Copy link
Contributor

pjcozzi commented Apr 6, 2018

@lilleyse is it realistic to scope this for 1.0? E.g., can this be done in one day or less and is it easy for Cesium to preserve backwards compatibility for existing tilesets and exporters?

@lilleyse
Copy link
Contributor Author

lilleyse commented Apr 9, 2018

This is in scope for 1.0. It seems like less than one day of effort and should not affect backwards compatibility with the CESIUM_RTC extension.

This could also be a good item to add to the upgrade command in 3d-tiles-tools - https://github.com/AnalyticalGraphicsInc/3d-tiles-tools/issues/142

@ggetz
Copy link
Contributor

ggetz commented May 11, 2018

Resolved in #301

@ggetz ggetz closed this as completed May 11, 2018
@caohaoze
Copy link

caohaoze commented Jun 8, 2018

I think we should add Local_Geo_Center to b3dm, rather than RTC_CENTER, because the geo-position can be applied to different ellipsoid.
For example, if we don't use the WGS-1984 ellipsoid, the b3dm with RTC_CENTER may not be placed on the surface of the new ellipsoid accurately.
If we store the Local_Geo_Center with (lon, lat, height), we can use Cesium to calculate the matrix before rendering. This setting can make the data adapt to any kind of ellipsoid.

@caohaoze
Copy link

caohaoze commented Jun 9, 2018

@lilleyse

@lilleyse
Copy link
Contributor Author

Hey @caohaoze, for now we are just trying to preserve the functionality of CESIUM_RTC. We may look into #286 for post-1.0 plans.

@lilleyse
Copy link
Contributor Author

In response to using other ellipsoids at runtime - the tiles would be positioned correctly but wouldn't the tile contents not fit properly? Either there would be intersections at the edges for smaller ellipsoids or gaps for larger ellipsoids.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants