Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conic sensor in BAMS scenario no longer rendering correctly. #242

Closed
mramato opened this issue Sep 17, 2012 · 5 comments · Fixed by #455
Closed

Conic sensor in BAMS scenario no longer rendering correctly. #242

mramato opened this issue Sep 17, 2012 · 5 comments · Fixed by #455

Comments

@mramato
Copy link
Member

mramato commented Sep 17, 2012

  1. Go here
  2. You'll notice the pinkish conic sensor is a skinny little thing, but if you look in the actual CZML file; the sensor parameters should be producing a very different looking primitive.

I already verified that the CZML is being correctly processed by DyanmicScene, so there are two places that could be the problem: either the CustomSensor primitive itself or the code we use to generate directions from conic inputs.

At first I thought this might have been caused by #152, but this doesn't seem to be the case.

@pjcozzi
Copy link
Contributor

pjcozzi commented Sep 17, 2012

Hmm. I haven't changed anything related to sensors recently. @bagnell do you think any of your changes could have impacted this? I kinda doubt it.

@mramato I assume the Sandcastle examples for custom sensors are OK? If so, did the generation code change recently?

@mramato
Copy link
Member Author

mramato commented Sep 17, 2012

I just tried it and I'm having problems getting either Complex Conic example to run (with or without Angle). Custom seems to work but generated unrelated errors (regarding the highlighting capability). @emackey I don't know if you are aware of issues in that demo, but you might want to check them out.

@mramato
Copy link
Member Author

mramato commented Sep 24, 2012

It would be nice to address this before we release r9, can someone take a look? @kring or @pjcozzi ?

@pjcozzi
Copy link
Contributor

pjcozzi commented Sep 24, 2012

Sorry, I can't - it's not on the Christmas list.

emackey added a commit that referenced this issue Sep 24, 2012
…@mramato mentioned in issue #242, but doesn't fix the original issue.
@mramato
Copy link
Member Author

mramato commented Jan 11, 2013

Fixed in above pull

@mramato mramato closed this as completed Jan 11, 2013
mramato added a commit that referenced this issue Jan 11, 2013
Fix incorrectly cached directions in the cone visualizer which was causing all conic sensors to have the same geometry.

This fixes #242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants