Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lighting regression #2635

Closed
mramato opened this issue Apr 15, 2015 · 7 comments
Closed

Lighting regression #2635

mramato opened this issue Apr 15, 2015 · 7 comments
Labels
priority - next release type - bug

Comments

@mramato
Copy link
Member

mramato commented Apr 15, 2015

532aa53 brings back the 2D/CV lighting issue that was fixed in #2515. The commit before it, f507210, does not have the issue. You can see this easily enough in the GeoJSON Sandcastle example.

I'm marking this a showstopper so that we at least look at it before 1.9.
@mramato
Copy link
Member Author

mramato commented May 1, 2015

Unfortunately this isn't going to make 1.9, but I'm leaving it as a showstopper so that we don't let it languish and try and fix it for 1.10.

@mramato
Copy link
Member Author

mramato commented May 1, 2015

Turns out this is OIT only now, since disabling fixes the issue. It also works on IE (I'm not sure if IE has extensions needed for OIT or not)

@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 1, 2015

Will look at post 1.10.

@mramato
Copy link
Member Author

mramato commented Jun 11, 2015

Recently came up again on the forum

@emackey
Copy link
Contributor

emackey commented Jun 19, 2015

Are there updated steps to reproduce this? The code sample from #1825 doesn't produce the results shown in the screenshot for me.

@mramato
Copy link
Member Author

mramato commented Jun 22, 2015

@emackey just run the GeoJSON Sandcastle example linked to in the description and switch to 2D.

image

@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 29, 2015

@bagnell thoughts on this? Is this an easy fix for 1.11?

@bagnell bagnell mentioned this issue Jun 29, 2015
Merged
@pjcozzi pjcozzi closed this as completed Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority - next release type - bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pjcozzi @emackey @mramato