New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Karma Support #3381
Initial Karma Support #3381
Conversation
…oved including SpecList
Also some minor cleanup.
Exciting! Can you please update any of the related Contributor's Guides in this branch? |
It looks like the original code just uses defineSuite and describe, so I think we're good. |
@mramato Also I didn't mean to do that merge, can I undo it somehow? |
OK |
I'll stop by. |
This is almost ready, I'm probably going to make some final tweaks (hopefully tonight) to better fit normal cesium dev workflow and then I'll merge. Thanks @ggetz. |
Awesome, thanks @mramato |
Use it to run tests from within WebStorm.
This PR just got more awesome. Building on @ggetz great work, I added Electron as a launcher option and set it to run headless. I then make it the default when running via WebStorm's own Karma runner. This means you can now run the tests from WebStorm with no additional windows or pop-ups and WebStorm presents the test in an easy to read tree with per-test output logs and clickable callstacks when things go wrong. @pjcozzi and @ggetz would you might syncing this branch and giving it one last try. After running Give it a try and let me know what you think. |
Works great. |
Also, add this to the test guide if you didn't already. |
|
This works great! Very cool! |
Also add `--browsers` flag for running against specific browsers.
I think the |
Okay, I also added a |
👍 |
Thanks @mramato ! |
Yay! Thanks @ggetz! :) |
Added Karma support as a first step for integrating tests as part of Travis-CI build process.
package.json
, including launchers for:test
andtest-all
targets togulpfile.js
test
runs karma tests using browser specified in config file, currently Chrometest-all
runs karma tests using all browsers availableTODO
Post merge
See #3571