Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terrain in 3d-tiles branch constantly refreshes #3690

Closed
tfili opened this issue Mar 9, 2016 · 8 comments
Closed

Terrain in 3d-tiles branch constantly refreshes #3690

tfili opened this issue Mar 9, 2016 · 8 comments

Comments

@tfili
Copy link
Contributor

tfili commented Mar 9, 2016

If you load a buildings tileset on Terrain, the terrain constantly reloads/unloads. I'll send the tileset offline. Just load that tileset in the Sandcastle 3dTiles example and enable terrain.

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 9, 2016

@lilleyse can you look at this? Perhaps also test the request scheduler branch off of master.

@lilleyse
Copy link
Contributor

lilleyse commented Mar 9, 2016

Yes I'll look into this.

@tsmith717
Copy link
Contributor

please ping me when this fix is in - we have 3 customers that need this. Thanks!

@lilleyse
Copy link
Contributor

lilleyse commented Mar 9, 2016

It looks like this is actually a bug in master, not 3d-tiles or RequestScheduler related. If you turn terrain on while the flat terrain is still loading, you may run into this issue.

@lilleyse
Copy link
Contributor

lilleyse commented Mar 9, 2016

Test with the following Sandcastle code:

var viewer = new Cesium.Viewer('cesiumContainer');
viewer.camera.setView({
    destination : Cesium.Cartesian3.fromRadians(-1.7057552114756511, 0.5283611246285218, 825.9580134720799)
});

Then quickly turn terrain on before the globe fully loads.

@lilleyse
Copy link
Contributor

lilleyse commented Mar 9, 2016

The problems are starting with: #3593 @bagnell You may have a better idea here.

This code should reproduce the problem:

var viewer = new Cesium.Viewer('cesiumContainer');
viewer.camera.setView({
    destination : Cesium.Cartesian3.fromRadians(-1.7057552114756511, 0.5283611246285218, 825.9580134720799)
});

var cesiumTerrainProviderMeshes = new Cesium.CesiumTerrainProvider({
    url : '//assets.agi.com/stk-terrain/world',
    requestWaterMask : true,
    requestVertexNormals : true
});

window.setTimeout(function() {
    viewer.terrainProvider = cesiumTerrainProviderMeshes;
}, 1000);

@bagnell
Copy link
Contributor

bagnell commented Mar 9, 2016

I found the issue and am working on a fix.

@pjcozzi
Copy link
Contributor

pjcozzi commented Apr 13, 2016

Fixed in #3696.

@pjcozzi pjcozzi closed this as completed Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants