Shadows #3856

lilleyse · 2016-04-15T18:45:42Z

This PR adds support for different types of shadows including cascaded directional shadows, spot light shadows, and point light shadows. It also adds the concept of derived commands which are used for OIT, shadows, and later 3D Tiles.

By default the scene contains a shadow map whose light source is the sun. It is disabled by default, but can be enabled with scene.shadowMap.enabled = true.

Shadow default settings:

Type	Casts Shadows	Receives Shadows
Globe	False	True
Primitives	False	False
Models	True	True

Any of these can change by setting castShadows or receiveShadows.

TODO

Testing TODO

TODO now or later

Use a good LOD when selecting tiles only in the shadow map frustum, e.g., not SSE from the light's perspective
Do not request imagery for tiles only in the shadow map frustum

Use cube map for point light shadows

Shadows point light

Soft shadows

pjcozzi · 2016-05-28T15:16:28Z

Source/Scene/QuadtreePrimitive.js

@@ -505,7 +505,8 @@ define([
    }

    function screenSpaceError(primitive, frameState, tile) {
-        if (frameState.mode === SceneMode.SCENE2D) {
+        // TODO: check for sseDenominator so shadow cameras with orthographic frustum works. check correctness.


What's the plan with this TODO? Roadmap?

Definitely relevant for the shadows-globe branch, but I can remove it from this.

pjcozzi · 2016-05-28T15:21:57Z

Source/Scene/ShadowMap.js

+         * @default false
+         * @private
+         */
+        dirty : {


This could just be a regular property without get/set functions.

pjcozzi · 2016-05-28T15:36:57Z

I submitted a few trivial style tweaks.

This is so close!

lilleyse · 2016-05-28T16:18:19Z

[.CommandBufferContext]GL ERROR :GL_INVALID_FRAMEBUFFER_OPERATION : glClear: framebuffer incomplete (clear)

Do you also see this error when running the tests?

lilleyse · 2016-05-28T16:35:06Z

Using the development Sandcastle example and the Shadow Tester 2 model, I noticed that disabling/enabling the normal offset shifts the shadow's location (on terrain, but not the model/primitive self-shadow).

Unfortunately this is a side effect of that technique. In the demo you can switch between bias modes, so if you turned it off/on for primitives you would notice the same thing. At some point these values worked well, but I think I can safely reduce them a bit now.

pjcozzi · 2016-05-28T16:36:30Z

Do you also see this error when running the tests?

Yes, when running http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/Specs/SpecRunner.html?spec=Scene%2FShadowMap

I get 27 of

SpecRunner.html:1 [.CommandBufferContext.Offscreen-MainThread-0x7ff8bd881150]GL ERROR :GL_INVALID_FRAMEBUFFER_OPERATION : glClear: framebuffer incomplete (clear)

pjcozzi · 2016-05-28T16:37:34Z

At some point these values worked well, but I think I can safely reduce them a bit now.

Sounds good.

Also, if the shadow shift is still noticeable, please document it so users that need ultra precision shadows can tune it.

lilleyse · 2016-05-28T16:59:07Z

Updated. I don't have my laptop with me so it's hard to investigate the OSX/Chrome error...

pjcozzi · 2016-05-28T20:32:07Z

Source/Scene/ShadowMap.js

        var polygonOffsetSupported = true;
        if (FeatureDetection.isInternetExplorer) {
            polygonOffsetSupported = false;
        }
        this._polygonOffsetSupported = polygonOffsetSupported;

+        // The normalOffset bias pushes the shadows forward slightly, and may be disabled


Put this in the reference doc so users will see it.

pjcozzi · 2016-05-28T20:33:07Z

@lilleyse what do you suggest? Wait to merge until we figure out the Mac issue? Or merge now to increase the chances of more people trying it out in master?

lilleyse · 2016-05-28T23:01:35Z

Updated. I was able to test it out and fix the problem.

pjcozzi · 2016-05-29T13:03:32Z

The WebGL error is gone, but I have one new shadow map test failure:

Ran 34 of 7358 specs - run all
34 specs, 1 failure
Spec List | Failures
Scene/ShadowMap directional shadow map
Expected [ 72, 72, 72, 255 ] to equal [ 240, 240, 240, 255 ].
Error: Expected [ 72, 72, 72, 255 ] to equal [ 240, 240, 240, 255 ].
    at stack (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/ThirdParty/jasmine-2.2.0/jasmine.js:1475:17)
    at buildExpectationResult (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/ThirdParty/jasmine-2.2.0/jasmine.js:1445:14)
    at Spec.expectationResultFactory (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/ThirdParty/jasmine-2.2.0/jasmine.js:584:18)
    at Spec.addExpectationResult (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/ThirdParty/jasmine-2.2.0/jasmine.js:332:34)
    at Expectation.addExpectationResult (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/ThirdParty/jasmine-2.2.0/jasmine.js:528:21)
    at Expectation.toEqual (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/ThirdParty/jasmine-2.2.0/jasmine.js:1399:12)
    at verifyShadows (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/Specs/Scene/ShadowMapSpec.js:373:26)
    at http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/Specs/Scene/ShadowMapSpec.js:623:9
    at Object.<anonymous> (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/Specs/spec-main.js:139:30)
    at attemptAsync (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/ThirdParty/jasmine-2.2.0/jasmine.js:1793:24)
Expected [ 72, 72, 72, 255 ] to equal [ 240, 240, 240, 255 ].
Error: Expected [ 72, 72, 72, 255 ] to equal [ 240, 240, 240, 255 ].
    at stack (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/ThirdParty/jasmine-2.2.0/jasmine.js:1475:17)
    at buildExpectationResult (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/ThirdParty/jasmine-2.2.0/jasmine.js:1445:14)
    at Spec.expectationResultFactory (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/ThirdParty/jasmine-2.2.0/jasmine.js:584:18)
    at Spec.addExpectationResult (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/ThirdParty/jasmine-2.2.0/jasmine.js:332:34)
    at Expectation.addExpectationResult (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/ThirdParty/jasmine-2.2.0/jasmine.js:528:21)
    at Expectation.toEqual (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/ThirdParty/jasmine-2.2.0/jasmine.js:1399:12)
    at verifyShadows (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/Specs/Scene/ShadowMapSpec.js:385:26)
    at http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/Specs/Scene/ShadowMapSpec.js:623:9
    at Object.<anonymous> (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/Specs/spec-main.js:139:30)
    at attemptAsync (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows/ThirdParty/jasmine-2.2.0/jasmine.js:1793:24)

The blinking also appears to be fixed, but I thought I saw it one time, but I can't reproduce it.

pjcozzi · 2016-05-29T13:05:43Z

Is #2594 completely up-to-date? There are still items above (#3856 (comment)) that are not included. Is this because you plan to do them before we merge this?

lilleyse · 2016-05-29T14:51:11Z

The problem there is most likely a z-fighting issue. I made a small change but I can't verify if it fixes the test. A lot of new aliasing problems like this are caused by changes in the browsers lately. In Chrome 49 polygonOffset seemed to work fine, but now there is no effect when toggling it in the demo.

lilleyse · 2016-05-29T14:51:57Z

Is #2594 completely up-to-date? There are still items above (#3856 (comment)) that are not included. Is this because you plan to do them before we merge this?

I moved the rest of the unfinished items here to the roadmap.

pjcozzi · 2016-05-29T15:16:42Z

All looks good now.

I saw the blink again, this time from a stationary view, perhaps due to new terrain tiles loading. If this is a common issue, we'll track it down.

pjcozzi · 2016-05-29T15:17:59Z

Also update CHANGES.md in master to include a link to the Sandcastle demo (using the future cesiumjs.org base path).

lilleyse · 2016-05-31T16:29:26Z

Also update CHANGES.md in master to include a link to the Sandcastle demo (using the future cesiumjs.org base path).

Done.

lilleyse and others added 30 commits March 9, 2016 11:17

Merge branch 'master' into shadows

1a6a07b

Fit to scene near and far

5190927

Rename farPlane to distance

7c0cb2c

Change lamda to 1.0

5759fa3

Rename fitToScene to cascadesEnabled

9b25230

Reorganize for point lights

11bdd01

Support point lights

3da9583

Fallback if depth FBO fails

4876a80

Use cube map for point light shadows

e2f05f6

Combine uniforms

692750b

Merge pull request #3718 from AnalyticalGraphicsInc/shadows-point-light2

9310f79

Use cube map for point light shadows

Handle shadow near/far better

0fe2fd5

Add TODO

b4c2a3b

Use separate fbo for each cubemap face

9726ff4

Rename sunShadowMap to shadowMap

7a5ec46

Only update point light cameras when point light moves

a98cbe8

Remove extra line

15c0362

Destroy fbo resources correctly for cube maps

162e5d0

Make render states immutable

3ebb190

Small tweak

1acd59f

Merge pull request #3711 from AnalyticalGraphicsInc/shadows-point-light

a471f00

Shadows point light

Simplify non-cube-map point shadows by always using a color texture

c34739f

Added pcf shadows

1c18a56

Make softShadows public

01d86c1

Rename stepSize to texelStepSize

87b5c3f

Merge pull request #3731 from AnalyticalGraphicsInc/shadows-soft

294e874

Soft shadows

Cleanup shader code

9ea57e4

Separate shaders for easier readability

6269e1a

Reset globe shaders when shadow map demo changes

da584b1

Tweak

b74db10

pjcozzi reviewed May 28, 2016
View reviewed changes

Whitespace

b38d1a1

pjcozzi reviewed May 28, 2016
View reviewed changes

pjcozzi added 2 commits May 28, 2016 11:24

Style tweak

0963097

Style tweaks

c21ae31

pjcozzi mentioned this pull request May 28, 2016

Shadows Roadmap #2594

Open

44 tasks

Many small updates

42dad26

pjcozzi reviewed May 28, 2016
View reviewed changes

lilleyse added 2 commits May 28, 2016 18:47

Fix FBO incomplete error

c688b0a

Tweaks

73c6631

lilleyse added 2 commits May 29, 2016 10:45

Depth fix

c8288b4

Merge branch 'master' into shadows

4713e12

pjcozzi merged commit bd3ddef into master May 29, 2016

pjcozzi deleted the shadows branch May 29, 2016 15:16

shunter mentioned this pull request Jun 15, 2016

Entity Shadows #4005

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shadows #3856

Shadows #3856

lilleyse commented Apr 15, 2016 •

edited

pjcozzi May 28, 2016

lilleyse May 28, 2016

pjcozzi May 28, 2016

pjcozzi commented May 28, 2016

lilleyse commented May 28, 2016

lilleyse commented May 28, 2016

pjcozzi commented May 28, 2016

pjcozzi commented May 28, 2016

lilleyse commented May 28, 2016

pjcozzi May 28, 2016

pjcozzi commented May 28, 2016

lilleyse commented May 28, 2016

pjcozzi commented May 29, 2016

pjcozzi commented May 29, 2016

lilleyse commented May 29, 2016

lilleyse commented May 29, 2016

pjcozzi commented May 29, 2016

pjcozzi commented May 29, 2016

lilleyse commented May 31, 2016

Shadows #3856

Shadows #3856

Conversation

lilleyse commented Apr 15, 2016 • edited

pjcozzi May 28, 2016

Choose a reason for hiding this comment

lilleyse May 28, 2016

Choose a reason for hiding this comment

pjcozzi May 28, 2016

Choose a reason for hiding this comment

pjcozzi commented May 28, 2016

lilleyse commented May 28, 2016

lilleyse commented May 28, 2016

pjcozzi commented May 28, 2016

pjcozzi commented May 28, 2016

lilleyse commented May 28, 2016

pjcozzi May 28, 2016

Choose a reason for hiding this comment

pjcozzi commented May 28, 2016

lilleyse commented May 28, 2016

pjcozzi commented May 29, 2016

pjcozzi commented May 29, 2016

lilleyse commented May 29, 2016

lilleyse commented May 29, 2016

pjcozzi commented May 29, 2016

pjcozzi commented May 29, 2016

lilleyse commented May 31, 2016

lilleyse commented Apr 15, 2016 •

edited