Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrix4.fromCamera should use position/direction... #3927

Closed
pjcozzi opened this issue May 18, 2016 · 0 comments
Closed

Matrix4.fromCamera should use position/direction... #3927

pjcozzi opened this issue May 18, 2016 · 0 comments
Labels
good first issue An opportunity for first time contributors type - bug

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented May 18, 2016

...not eye/target, which no longer exist.

See Matrix4.fromCamera and Camera. The tests pass because they are explicitly creating an object literal instead of using a Camera instance.

Also, is there anywhere in Cesium that isn't using fromCamera, but should? I suspect it is not used at all or not used in common code paths since they would be broke.

Reported by @anne-gropler in #129 (comment).

@lilleyse this is a good beginner issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An opportunity for first time contributors type - bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pjcozzi