Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kml file loading regression: works in 1.25, not 1.26 "Cannot read property 'center' of undefined" #4431

Closed
vrittis opened this issue Oct 14, 2016 · 4 comments · Fixed by #4461
Closed

Kml file loading regression: works in 1.25, not 1.26 "Cannot read property 'center' of undefined" #4431

vrittis opened this issue Oct 14, 2016 · 4 comments · Fixed by #4461
Labels
priority - next release type - bug

Comments

@vrittis
Copy link

vrittis commented Oct 14, 2016

The attached kml file loads correctly in 1.25, but fails with the following error message in 1.26:

An error occurred while rendering. Rendering has stopped.
TypeError: Cannot read property 'center' of undefined
TypeError: Cannot read property 'center' of undefined
at updateBatchTableBoundingSpheres (http://localhost/geosportardeche/DesktopModules/CG.EarthMapMaker/js/Cesium/Cesium.js?v1:93495:40)
at Primitive.update (http://localhost/geosportardeche/DesktopModules/CG.EarthMapMaker/js/Cesium/Cesium.js?v1:93890:13)
at GroundPrimitive.update (http://localhost/geosportardeche/DesktopModules/CG.EarthMapMaker/js/Cesium/Cesium.js?v1:98060:25)
at PrimitiveCollection.update (http://localhost/geosportardeche/DesktopModules/CG.EarthMapMaker/js/Cesium/Cesium.js?v1:157993:27)
at updatePrimitives (http://localhost/geosportardeche/DesktopModules/CG.EarthMapMaker/js/Cesium/Cesium.js?v1:166211:33)
at executeCommandsInViewport (http://localhost/geosportardeche/DesktopModules/CG.EarthMapMaker/js/Cesium/Cesium.js?v1:166122:9)
at updateAndExecuteCommands (http://localhost/geosportardeche/DesktopModules/CG.EarthMapMaker/js/Cesium/Cesium.js?v1:165990:17)
at render (http://localhost/geosportardeche/DesktopModules/CG.EarthMapMaker/js/Cesium/Cesium.js?v1:166420:9)
at Scene.render (http://localhost/geosportardeche/DesktopModules/CG.EarthMapMaker/js/Cesium/Cesium.js?v1:166458:13)
at CesiumWidget.render (http://localhost/geosportardeche/DesktopModules/CG.EarthMapMaker/js/Cesium/Cesium.js?v1:175280:25)

I wasn't able to determine if it was a problem with the quantity of geometries in the file or the mix between polygon and multigeometries. I stripped down the kml file for the issue, the polygons are much more complex usually. However the error happens even with four points polygons. There are 3423 placemarks in the file.

Fail1.26.kml.zip
@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 15, 2016

@bagnell can you look at this at the bug bash?

@tfili
Copy link
Contributor

tfili commented Oct 19, 2016

@bagnell The document for #4041 is also showing this issue.

mramato added a commit that referenced this issue Oct 19, 2016
@mramato
Fix updateBatchTableBoundingSpheres
85ced9b 
updateBatchTableBoundingSpheres was using the BoundingSphere center without
applying the modelMatrix to the sphere first.


Fixes #4431 and #4428
@mramato mramato mentioned this issue Oct 19, 2016
Merged
@hpinkos hpinkos mentioned this issue Oct 20, 2016
Closed
@mramato
Copy link
Contributor

mramato commented Oct 21, 2016

@bagnell it looks like loading this file in master causes lots of undefined bounding spheres, while everything works as expected in 1.25. I'm assuming this is batch-table related.

@pjcozzi pjcozzi reopened this Oct 21, 2016
@mramato
Copy link
Contributor

mramato commented Oct 26, 2016

@bagnell let's discuss this and #4414 when you get in today. This one in particular is a geometry-wide regression and not just KML.

@mramato mramato mentioned this issue Oct 26, 2016
Closed
@bagnell bagnell mentioned this issue Oct 26, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority - next release type - bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix updateBatchTableBoundingSpheres CesiumGS/cesium
4 participants
@vrittis @pjcozzi @mramato @tfili