Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OrthographicFrustum missing from documentation #5586

Closed
slozier opened this issue Jul 5, 2017 · 1 comment
Closed

OrthographicFrustum missing from documentation #5586

slozier opened this issue Jul 5, 2017 · 1 comment
Labels
category - doc good first issue An opportunity for first time contributors

Comments

@slozier
Copy link
Contributor

slozier commented Jul 5, 2017

OrthographicFrustum is missing from the documentation. I see that @alias OrthographicFrustum got changed (#5021) to @alias OrthographicOffCenterFrustum so the documentation got merged with OrthographicOffCenterFrustum. Was this on purpose? This creates duplicate near/far entries in the OrthographicOffCenterFrustum documentation.

Also the example code in OrthographicFrustum.js got changed to use OrthographicOffCenterFrustum instead of OrthographicFrustum.
@mramato mramato added good first issue An opportunity for first time contributors category - doc labels Jul 5, 2017
@mramato
Copy link
Contributor

mramato commented Jul 5, 2017

Thanks for the report, this is definitely a doc bug. We're happy to take a PR to fix this.

@slozier slozier mentioned this issue Jul 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category - doc good first issue An opportunity for first time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mramato @slozier