Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated addQueryParameters and addTemplateValues #7695

Merged
merged 1 commit into from Apr 1, 2019
Merged

Remove deprecated addQueryParameters and addTemplateValues #7695

merged 1 commit into from Apr 1, 2019

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Apr 1, 2019

addQueryParameters and addTemplateValues were supposed to have been removed in 1.45.

Also changed the fetchImage deprecation removal to be next month since it was added this month.

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse lilleyse mentioned this pull request Apr 1, 2019
Closed
@hpinkos hpinkos merged commit 141c786 into master Apr 1, 2019
@hpinkos hpinkos deleted the resource-breaking-changes branch April 1, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
priority - next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lilleyse @cesium-concierge @hpinkos