Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot call sampleTerrainMostDetailed on ArcGISTiledElevationTerrainProvider #8007

Closed
OmarShehata opened this issue Jul 16, 2019 · 3 comments · Fixed by #9286
Closed

Cannot call sampleTerrainMostDetailed on ArcGISTiledElevationTerrainProvider #8007

OmarShehata opened this issue Jul 16, 2019 · 3 comments · Fixed by #9286

Comments

@OmarShehata
Copy link
Contributor

This came up on the forum. If you try calling sampleTerrainMostDetailed on an ArcGISTiledElevationTerrainProvider it complains that:

sampleTerrainMostDetailed requires a terrain provider that has tile availability.

Sandcastle link.

But you can see that it does compute an availability here: https://github.com/AnalyticalGraphicsInc/cesium/blob/3601fc73247ab3526c4f18be38ccc8c1860a541b/Source/Core/ArcGISTiledElevationTerrainProvider.js#L158 It just doesn't seem to expose it as a property.

If I just throw a .availability property, the call works but the returned height is undefined. I traced this to terrainData.interpolateHeight returning undefined here: https://github.com/AnalyticalGraphicsInc/cesium/blob/3601fc73247ab3526c4f18be38ccc8c1860a541b/Source/Core/sampleTerrain.js#L107 Everything that's passed in looks fine, so I'm not sure why it's undefined (and it correctly figured out that the max level at this point is 16).

@tfili

@OmarShehata
Copy link
Contributor Author

Came up again on the forum.

@smills2929
Copy link

It's worth mentioning that you can't call sampleTerrain at all. It's not just 'sampleTerrainMostDetailed' that doesn't work.

@cesium-concierge
Copy link

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/d/msg/cesium-dev/grjkeKWG9Ig/fGsnzkEMAgAJ
https://groups.google.com/forum/#!topic/cesium-dev/6e2E4lTXvgw

If this issue affects any of these threads, please post a comment like the following:

The issue at #8007 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants